This message was deleted.

hmm weird

cmd+j

should definitely allow you to just leave comments

cc @merrill / @Xiulung Choy on the discussion we had a while back

this is a limitation of github which requires a review to add comments. the

cmd

+

j

should submit thread comments if you press it while on the pr page and have pending comments. it doesn't work while the review modal is open and or if you're in a text box somewhere. Where have you tried using it?

Right, so there's no way to add thread comments as single comments via the API like in the GitHub UI? I was under the understanding that cmd + j would allow me to leave a single reply without having to submit a review! If this is a limitation of the API then that's totally all good 😃

@Jonny O'Mahony, confused what you mean by cmd j not working for you. I just tested and it works. So my flow is: 1.

Add reply

on existing thread or start a new thread via clicking on the line numbers 2. Type comment 3. cmd enter to save the thread 4. cmd j to save the review

@Aryaman oh! Then I was being stupid. I was attempting to use cmd + j instead of cmd + enter! God that really makes me look dumb haha. With that, I don't need to enter a review then?

After you hit cmd enter, your thread comment will be saved as draft, and then you will have to do cmd j to actually publish it. Ideally we should make this a single shortcut rather than requiring two steps (cmd j, cmd enter).

Riiight! That's where my understanding broke down. I thought it was a single shortcut. Will give this a go asap, thanks again!

Take a look at this video for the full flow if you still have questions. I hit cmd enter at 18 seconds, and cmd j at 24 seconds.

Exactly what I'm looking for, thank you!! (A button for idiots like me for this would be great)

Agree, we're thinking about this 🙂

that's on us for not making this clear! as everyone else said, we're thinking about the ergonomics here