This message was deleted.
# report-bugss
Slackbot
02/07/2023, 5:27 PMThis message was deleted.
p
Pranathi Peri
02/07/2023, 6:09 PMIs this specifically in the review queue, on the PR page or both?
b
Ben Jaffe
02/07/2023, 6:50 PMI’m noticing it on the review queue.
p
Pranathi Peri
02/07/2023, 6:51 PMLooking into this!
b
Ben Jaffe
02/07/2023, 6:51 PMThank you!
j
Jacob Gold
02/07/2023, 9:51 PMCan you send me an example PR org/repo/number? Note that if the PR was in a stack, but its base branch was merged, and it hasn't yet had its base change to the trunk branch, then we might be basing this on GitHub's (now inaccurate) calculation
b
Ben Jaffe
02/07/2023, 11:45 PMBen Jaffe
02/07/2023, 11:45 PMthat one is based on
mainBen Jaffe
02/07/2023, 11:46 PMI can wait on merging it until tomorrow so you can dig into its current state
j
Jacob Gold
02/07/2023, 11:47 PMThanks!
b
Ben Jaffe
02/10/2023, 12:49 AMChecking in — if I merge this PR, will you still be able to debug this state?
j
Jacob Gold
02/10/2023, 1:03 AMJust looked and I think we got everything we need, so you're good to merge.
This class of issue is interesting as we didn't change anything here recently — github seems to have changed some logic around one of their api response fields. The good news is that we were planning on doing more of these calculations on our end, but I'm not sure quite when that change is going to roll out.
b
Ben Jaffe
02/10/2023, 1:04 AMAwesome, I’ll merge then. FWIW, I’ve noticed this happening for about as long as I’ve been using Graphite, so it might be a long-standing issue that I’m hitting for some reason
Ben Jaffe
02/10/2023, 1:05 AMIt’s confusing though — since it’s not a more widely reported issue on this Slack, maybe it’s something about me or the repo.