This message was deleted.
# report-bugss
Slackbot
02/08/2023, 6:23 AMThis message was deleted.
š 1
b
Ben Jaffe
02/08/2023, 6:24 AMIf I had to guess, Graphite might think these PRs are still merging because CI on
mainBen Jaffe
02/08/2023, 6:25 AMAnd if it is a known issue, is there a way to get them out of the list?
Ben Jaffe
02/09/2023, 7:41 PMPing in case my message slipped by, @Pranathi Peri
p
Pranathi Peri
02/09/2023, 8:10 PMHi sorry about that! Let me look into it!
Pranathi Peri
02/09/2023, 9:48 PM@Ben Jaffe, could you send a screenshot of what the filter conditions on this section are?
Pranathi Peri
02/09/2023, 9:50 PMIt's possible that the "last updated" condition could be very large in this scenario
Pranathi Peri
02/09/2023, 9:51 PMAlso, is this just a "merging" section or both "merging/recently merged?"
b
Ben Jaffe
02/09/2023, 10:03 PMAlso I noticed that the alt text for the merged icon says āMergedā in the list.
p
Pranathi Peri
02/09/2023, 10:15 PMI see, I think the merging/rebasing filters could be a bit buggy - looking at a fix! Thanks for reporting this!
b
Ben Jaffe
02/09/2023, 10:56 PMThank you!
p
Pranathi Peri
02/10/2023, 5:32 PMWe killed some jobs last night so this may be fixed!! Let me know if it's still an issue
b
Ben Jaffe
02/10/2023, 6:24 PMAlas, noā¦ theyāre still showing up
Ben Jaffe
02/10/2023, 6:25 PMBen Jaffe
02/22/2023, 4:55 PM@Pranathi Peri Reviving this ā is there something I can do to get those old PRs out of the Merging section? The top two are currently merging, but the rest have been there for weeks. I believe they all had CI failures when they landed on
mainp
Pranathi Peri
02/22/2023, 4:56 PMcc @Jacob Gold
a
Aryaman
03/06/2023, 7:41 PMIIUC @Ben Jaffe you only want to see the currently "merging" PRs there? And not merged ones?
Aryaman
03/06/2023, 7:41 PMOr is the issue that a PR failed to merge, and now is stuck in the merging section?
b
Ben Jaffe
03/06/2023, 7:42 PMActually, not quite either. The PRs that are stuck have successfully merged, and graphite knows this (at least in the status icon)
Ben Jaffe
03/06/2023, 7:43 PMAlmost all of them had CI failures
Ben Jaffe
03/06/2023, 7:44 PMbut they merged just fine (we had a CI outage, and the PRs were safe to merge). So it seems like theyāre in a weird state on the Graphite side and not getting unstuck. Hereās the section settings, for completeness.
a
Aryaman
03/06/2023, 7:44 PMAh, and these should be filtered our from the
mergingb
Ben Jaffe
03/06/2023, 7:45 PMYes, Iād expect them to not show up because they sucessfully merged.
a
Aryaman
03/06/2023, 7:46 PMYes that is reasonable
Aryaman
03/06/2023, 7:46 PMLet me take a look
b
Ben Jaffe
03/06/2023, 7:47 PMthank you!
j
Jacob Gold
03/06/2023, 7:48 PMwhat are their PR numbers?
b
Ben Jaffe
03/06/2023, 7:49 PM3405, 3404, 3403, 3337, 3327, 3201
a
Aryaman
03/06/2023, 7:54 PM@Ben Jaffe what is your github handle?
j
Jacob Gold
03/06/2023, 8:02 PMah, I think I have a fix for this
graphite 1
Jacob Gold
03/06/2023, 8:03 PMtry refreshing!
b
Ben Jaffe
03/06/2023, 8:08 PM@Aryaman benjaffe
Ben Jaffe
03/06/2023, 8:09 PM@Jacob Gold OMG YOU ARE MY HERO!
Ben Jaffe
03/06/2023, 8:09 PMIt worked!
Ben Jaffe
03/06/2023, 8:09 PMWhat was the issue?
j
Jacob Gold
03/06/2023, 8:09 PMwe had some bad rows in the db š¬
b
Ben Jaffe
03/06/2023, 8:10 PMIām very grateful, thank you.
Ben Jaffe
03/06/2023, 8:10 PMI have one remaining issue with all this state around people approving PRs, but they donāt change from āWaiting for reviewersā to āApprovedā, but Iām guessing thatās unrelated to this
Ben Jaffe
03/06/2023, 8:11 PMDoes āReview status is: Approvedā mean one or more approval?
a
Aryaman
03/06/2023, 8:11 PMYou should see improvements in the accuracy of the sections coming soon.
b
Ben Jaffe
03/06/2023, 8:11 PMoh okay awesome!
Ben Jaffe
03/06/2023, 8:11 PMIāll wait then š
graphite 1
j
Jacob Gold
03/06/2023, 8:13 PMI believe for approval status the issue is related to the GitHub API returning an incorrect calculation of whether the PR is accepted ā we're improving our own derivations of this sort of thing š
ā¤ļø 1