https://linen.dev logo
Join Slack
Powered by
This message was deleted.
# announcements
s
This message was deleted.
p
Ahh sorry you're running into this @Ryan Rhee!! We're looking into this now!
Do you mind DMing a PR number to help with debugging?
r
i actually merged it using githubs ui and 
gt rs && gt sr
heh
if i run into it again i’ll post the PR number
p
Ah ok no worries, keep me posted!
r
DM’ing you
r
You can try invalidation of caches.
r
that worked, thank you!
🙌 1
nope, spoke too early. it was ok until i clicked on a few PRs.
it seems like only certain PRs are affected.
p
Hmm ok sorry about that - go ahead and DM me those PRs!
r
this is how i’m clearing the cache.
p
@Brendan Ngo took a look at this PR and looks like the stack dependency table is incorrect - if this is blocking, he can go ahead and fix this manually. Otherwise this is a bug that we'll look deeper into!
r
i made these PRs with “gt ss” and didn’t do anything special. this particular pr is not blocking, but if I create new PRs some of those will end up in this state as well.
oh actually i made the first PR with vscode’s GitHub integration and the subsequent prs with gt ss
b
the problem I saw was we were missing the first PR in our dependency table so makes sense now if you created it not with Graphite
r
graphite cli seemed to know the dependency since I used gt track on the first PR. sounds like graphite needs to update the dependency table if a branch is tracked manually, or if a stack is submitted and parts of that stack are not in the dependency table?
b
I think that's generally true. we update the dependency table on submit which I believe should handle this. Next time you see this can you try 
gt ss --always
so force submit updates?
r
yes, i’ll try that next time and report back. thanks!
b
also if you have a steady repro please let us know! would love to root cause this if possible. Thanks again for reporting!
r
i’m pretty sure the repro is: 1. create first PR using github’s vscode integration; using github’s 
hub
cli probably also works? 2. create a 2nd PR on top of PR1 using 
gt ss
3. (optional) create 3rd PR on top of PR2 using 
gt ss
but the next time i do this flow i’ll confirm that it breaks the dependency table.
b
just verifying you are also tracking the first pr with 
gt branch track
?
r
oh yeah, forgot that part
you’re correct, i am tracking the first branch after pr creation
👍 1
ggt ss --always
did not fix the first PR of the stack; graphite webapp still doesn’t show the first PR as a part of the stack.
b
Thanks for trying! We've filed a ticket for this and will look into. For now you can probably avoid this by creating all your prs with Graphite. Also 
gt ss
just submits the prs. Are you using graphite to create/manage your branches also?
r
i’m creating branches with 
gt bc -m ...
i sometimes have to 
track
if i rename a branch after 
gt bc
. i rename the branch via 
git branch -m $old_name $new_name
if there’s a graphite command to rename a branch i can try using that as well
b
the graphite command for renaming a branch is 
gt branch rename
(alias 
gt brn
)! Note that this removes any associated GitHub pull request.
r
good to know, thank you!
Open in Slack
PreviousNext
Powered by