Does Diamond know the location of file-based rules? It's awesome to see that Diamond now supports rules defines in checked in files! 🎉 I want to find out if an idea I have would would work... Problem There are some "localized gotchas" I would like Diamond to pay extra attention to. They're fairly trivial things, just easy to miss by a human and not possible to enforce with a linter or typechecker. Two examples: 1. In a

pytest

file which contains Python service fixtures, instantiate dependent services from scratch (using a shared DB session), instead of using their global fixtures. 2. If the content of an external-facing docs page changes significantly, review the frontmatter

description:

property of the relevant

.mdx

file. Solution I'm hypothesising Wanted to create a custom file-based Diamond ruleset for these gotchas, based on globbing a pattern like

*.diamondrules

. I wanted to start with a

/.root.diamondrules

file like this:

# What are `.diamondrules` files?

Files with the `.diamondrules` extension are used to define "localized gotchas" to pay careful attention to.

As an AI code reviewer:

1. Diligently follow the procedures described by these rules.
2. Apply these rules to files in the same directory as the `*.diamondrules` file, especially if it references a specific relative file.

And then we'd put write extra

.*.diamondrules

files as needed in each dir, for example:

# Maintaining consistent `description` Frontmatter property

Whenever an `*.mdx` file in this directory is modified, review that the `description` Frontmatter property matches the updated content of the file.

Some Qs: 1. Do you think this would work? 2. When you concatenate the globbed files, does the resulting prompt / tool call output also give diamond the location of each file? 3. Can Diamond look over the whole file when doing code review? In these gotchas sometimes context more than a few hundred lines away from the diff is important. CC @Alyssa Baum for thoughts

For suggested edits in Graphite (with Diamond), it'd be very helpful to be able to configure a pre-commit hook to be run. Devs on our team are reluctant to commit those suggestions because often the outcome is it violates a lint rule (or type check) that then result in CI check failure. Locally, our pre-commit hook catches this and prevents the commit.

I would love it if the Mac menu bar app could optionally be shown in the dock icon with a notification badge. I always miss when I have new PRs needing review because I'm not used to looking in the menu bar for a badge - most other apps show a red notification badge on the dock icon. Alternatively, if there was a way to access this metric via an API then I could vibe code a quick desktop app myself!

Feedback on new PR page: description placement is not 'visually centered' as it accommodates the PR details in top right 😅 i.e. it's literally centered in its 'column' in the layout/grid, but PR details are tiny and make it feel 'unbalanced' ⚖️

May I request issue tracking integration with Zenhub?

Any way to make the new PR page more vertically stacked? I don't always work on a large monitor, and the sheer number of horizontal panes make the diff I'm reviewing quite small on the center of the page

Can y'all make the right side pane sticky while I scroll down the description? Otherwise I get a bunch of blank space on the right when I scroll down long PR descriptions. It's also kinda hard to access the right pane unless there's an easier way to scroll back to the top of the page.

Is there a way to manually link stacks from different repos? I get graphite is built on top of the git history, and we have a few services spanning different repositories that we make changes to as part of a single piece of work / feature. It would be really handy to be able to link a commit / PR in one repo inside a stack of another for the reviewer to see all the changes in logical order instead of also needing to switch back forward between stacks. Not sure if possible but would be a cool feature to have

I would love to be able to provide an MCP to Diamond, so it can have more context on my projects

this is somewhere between #C06C4TH0D27 and "show and tell" ... i found the various icons in rows to be hard to see, so i made a little Stylus script to color the rows not super stylish, but does the job 🤠

Are there plans to add more tools to the MCP? It would be great for example to give references of PR comments to the agent

Make it faster! loading PRs takes ages... seeing the Graphite logo for some seconds then pr loads for some time then files take more time

The "new PR page" used to show HTML comments inline which was actually kind of nice. Now they're totally invisible. We use them in our PR template to describe what's expected in each section. Also, I enjoy the WYSIWYG editor in the new version, but having a way to switch to plain Markdown is table-stakes for a developer oriented product.

Is there a way to have Diamond run even for not published PRs? I want to address any potential AI feedback before I turn the PR over to other humans.

ah, that does sound right. i guess this is a feature request to ignore checks and perform the merge like i'm able to on gh's PR page then 🤠 Thread in Slack Conversation

refreshing my desire for phabricator/differential style

gt suggest

(add changes i've made locally after `gt get`ing somone else's PR as suggested edits)

For merge queue, adding schedules would be nice for automatic freezing.

Zed ide extension

extension for code review with diamond

Would be nice to have a cli subcommand to push all prs/stacks after a

gt sync

restacked them all ... having to iterate and push one at a time is no fun nevermind, thanks @Vampire for the lesson!

please 🥺 i just need to view a

blame

sometimes and the

raw

file doesn't cut it. it's super inefficient having to manually do like 5 extra steps to get to a file from graphite's PR page. i'd love if graphite just provided a link to the actual 'rich' file on github 🙏 ❌ not useful 99% of the time

<https://raw.githubusercontent.com/org-name/repo-name/12345commithash67890/path/to/file>

✅ useful constantly

<https://github.com/org-name/repo-name/blob/12345commithash67890/path/to/file>

Thread in Slack Conversation

It'd be nice if we could opt to use merge instead of rebasing for restacking.

There should be a "gt pull" (or equivalent) that automatically pulls all remote stacks onto my machine (similar to git pull) instead of having to run gt get XYZ with no autocomplete

We use `mermaid`(https://mermaid.js.org/) diagrams that Claude generates for us and posts as comments on github like

mermaid
sequenceDiagram
   blahBlah

On github this shows up as a diagram but on graphite it just shows up as raw markdown code block

sequenceDiagram
   blahBlah

Is it possible to add

mermaid

support?

I feel like cmd-k should be able to be a lot faster if i type in the exact pr number

it would be awesome if comments in Graphite's PR view showed which version was active when the comment was made

We sometimes have a stack of PRs to simplify the review process, but we do not want to merge the PRs individually - only the full stack at once. I'd like the ability to fold a stack before merging, and the ability to create stacks with a fold-and-merge when ready flag.

I have some devs who only use the ai-generated PR description, which is negative value for me - I care more about why they're making the change, and what alternatives they considers. I'd like to disable ai summaries for my tenant completely as a feature flag.

I’d love it I could easily create a Linear ticket from a PR thread. Let’s say we had some discussion on a PR where something could be improved by caching. I may not want it to be a blocker for merging that PR, but I would want a Linear ticket to add that caching so we don’t forget and lose track of it. Right now, I’ll leave a comment asking the PR author to create that linear ticket before resolving the discussion thread. Would be great if Diamond could just do it for me.

Hi We used to use the github integration in linear to automatically close tickets when their respective PR is closed. When we added CI Settings to not run CI on every PR in the stack, it has this note:

Note: A temporary PR will be created for every CI run which will include all the commits from PRs in that stack. After merging, this temporary PR will be marked as 'closed' on both Graphite and GitHub. Learn more

Unfortunately this breaks the github integration in linear - since the PR with the ticket is "closed" rather than "merged", and the temporary PR is what is merged instead. Is there a workaround for this? Or - idea - can we add this type of integration into the graphite integration to linear? Would be great if this integration had the same ability of the github one to manage ticket status