my contribution to grails-plugins/grails-elasticse...
# questions
u
my contribution to grails-plugins/grails-elasticsearch https://github.com/grails-plugins/grails-elasticsearch/pull/209 was autoclosed by CLAassistant. Could someone give me a hint how to sign the CLA?
s
Looks like it was denied because some of the commit attributions cannot be tied to a github user. You need to remove attributions to the none github user.
u
ok, will try tomorrow
j
And the CLA is no longer used on Grails-plugins, as far I know, so if you create a new PR, it should be able to proceed. A 4.0.x branch was created for Grails 7.x.x work 2 weeks ago
u
Ok, my current work is grails 5/6, but I will try to port it to grails 7, because we will need it anyway in the near future...
❤️ 1
u
I have published a new merge request under https://github.com/grails-plugins/grails-elasticsearch/pull/233
u
It seems to need Java 11 or newer to function, could anyone update the CI-job?
j
I moved it forward, but had to create a new PR, since I could not push to your branch. Please address comments on https://github.com/grails-plugins/grails-elasticsearch/pull/233 and then we will merge your PR into the one I created which will give use Grails 5 snapshtos on the 4.0.x branch
u
Ok, thanks a lot, will do!
u
I made the requested changes and commented on some points. @James Fredley Could you please have a look at the merge request again?
j
I am tied up at a conference and will try to look later in the week. Thank you for tackling this plugin. It was one that we decided not to move to Apache at the time due to recency of updates and I am glad you took on the updates.
👌 1
u
u
will you do a final 4.0.0 release for grails 5/6 or shall we upgrade to grails 7 before releasing 4.0.0?
j
Sounds awesome, My schedule is a bit nuts, so please start a new thread in #C07M0GTDE if I do not reply in a timely manor