This message was deleted.
# plugin-developments
Slackbot
10/31/2022, 4:54 AMThis message was deleted.
v
Vampire
10/31/2022, 7:55 AMCan you share your code? Especially the past where you schedule the worker?
t
thadhouse
10/31/2022, 11:05 AMhttps://github.com/wpilibsuite/deploy-utils/blob/54486e042560eb36ee480f0839f9d71f75068c2e/src/main/java/edu/wpi/first/deployutils/deploy/target/discovery/TargetDiscoveryTask.java#L74
The service itself is expected not to be serializable. There is an object I have to pass to the worker that will never be serializable. In the past I’ve used a static variable to handle this, and the documentation made it seem like build services could be passed without the need to be serializable.
v
Vampire
10/31/2022, 11:12 AMStatic state is always problematic, yes, because it will partially be available cross-build-runs and thus influence other build runs or in some cases even other projects built in the same Gradle daemon.
Regarding your error, it is like I assumed, you are not following the docs you linked to yourself.
It says:
To do this, pass the build serviceBut what you do is to get the service from the provider and then give that instance to the worker, that will not work.as a parameter of the consuming action or service, in the same way you pass other parameters to the action or service. For example, to pass aProviderservice to worker API action, you might add a property of typeMyServiceTypeto the action’s parameters object and then connect theProperty<MyServiceType>that you receive when registering the service to this property.Provider<MyServiceType>
t
thadhouse
10/31/2022, 11:15 AMSo it needs to be a property of a property? I guess that makes sense, but the docs are not super clear on that. In some places in the docs, I’ve seen this quote
“ a property of type property ‘property<thing>” mean just a property<thing>, not a property<property<thing>>. So the docs are confusing there.
thadhouse
10/31/2022, 11:26 AMI’m hopeful this is finally a workaround to needing static state. I know it’s a problem, and can cause issues, but for our specific case we needed to pass an ssh context to the worker, and that will never be serializable. But if it’s a service and guaranteed to be build specific, that removes the static requirement and massively helps us.
v
Vampire
10/31/2022, 12:52 PMNo, not a property of a property. You are just doing the wiring wrongly
Vampire
10/31/2022, 12:53 PMWhat you have is
Copy code
StorageService storageService = getStorageService().get();
getWorkerExecutor().noIsolation().submit(TargetDiscoveryWorker.class, config -> {
config.getStorageService().set(storageService);
} Copy code
StorageService storageService = getStorageService().get();
getWorkerExecutor().noIsolation().submit(TargetDiscoveryWorker.class, config -> {
config.getStorageService().set(getStorageService());
}Vampire
10/31/2022, 12:54 PMYou need to wire the provider to the provider and not give the actual instance to the provider.
2 Views