How do I do this in a configuration-cache-friendly...
# configuration-cachet
twisterrob
05/18/2024, 10:10 PMHow do I do this in a configuration-cache-friendly way?
Copy code
tasks.named("a").configure {
doLast {
if (tasks.named("b").map { it.state.failure != null }.get()) {
println("b failed")
}
}
}twisterrob
05/18/2024, 10:10 PMIt fails because
tasksProject Copy code
1 problem was found storing the configuration cache.
- Task `:a` of type `A`: cannot serialize object of type 'B', a subtype of 'org.gradle.api.Task', as these are not supported with the configuration cache.twisterrob
05/18/2024, 10:11 PMI also tried this, but
TaskContainer Copy code
abstract class TaskFailedValueSource : ValueSource<Boolean, TaskFailedValueSource.Params> {
@get:Inject abstract val taskContainer: TaskContainer
interface Params : ValueSourceParameters {
val taskName: Property<String>
}
override fun obtain(): Boolean =
taskContainer.getByName(parameters.taskName.get()).state.failure != null
}twisterrob
05/18/2024, 10:11 PMAm I missing a very obvious solution? Is it not possible?
twisterrob
05/18/2024, 10:12 PMOh, I also tried putting the whole Provider<Boolean> outside, but then it gets resolved during CC-save, which is too early, the value is always
falsev
Vampire
05/19/2024, 9:28 AMI think what you need is a shared build service that you also register as operation completion listener. Then you can record the outcome of B in the service and query it from the service in A.
t
twisterrob
05/19/2024, 9:29 AMPff, makes sense, thank you! But at the same time, it doesn't, that feels way too complex for a simple task like this.
🤷♂️ 1
twisterrob
05/19/2024, 4:00 PMThank you again, this seems to work:
Copy code
// Note to reader: both registerIfAbsent and onTaskCompletion can be called many times, they're idempotent.
val taskStateService = project.gradle.sharedServices
.registerIfAbsent("taskState", TaskStateService::class.java) { }
serviceOf<BuildEventsListenerRegistry>().onTaskCompletion(taskStateService)
val bTaskPath = "${project.path}:b"
tasks.named("a").configure {
usesService(taskStateService)
doLast {
if (taskStateService.get().isFailed(bTaskPath)) {
println("b failed")
}
}
}
abstract class TaskStateService : BuildService<BuildServiceParameters.None>, OperationCompletionListener {
private val state: MutableMap<String, TaskFinishEvent> = mutableMapOf()
fun isFailed(taskPath: String): Boolean {
val state = state[taskPath] ?: error("Task ${taskPath} is not complete yet.")
return state.result is TaskFailureResult
}
override fun onFinish(event: FinishEvent) {
if (event is TaskFinishEvent) {
state[event.descriptor.taskPath] = event
}
}
}v
Vampire
05/19/2024, 8:59 PMGreat, but be aware that
serviceOft
twisterrob
05/19/2024, 9:01 PMYeah, I know, I'm too lazy to do that interface + objects dance for a hack that hopefully doesn't stay long, or if it does it's still an end project, not a plugin.
👌 1
twisterrob
05/19/2024, 9:01 PMFor fun: I used this while integrating a Compose screenshot testing lib with version 0.0.1-alpha01, can't get lower than that I guess with a named version.
5 Views