Slackbot
07/06/2023, 6:39 PMVampire
07/06/2023, 6:42 PMext is practically always bad practice and you should feel dirty every tiem you use it. 😉
And yes it does, especially when changing versions. Because if you have the versions in code, it needs to be recompiled and classpaths change and thus also make things out-of-date that shouldn't be.
With version catalog (if defined a TOML that is) the build logic stays the same and only the things where really something changed due to the different version has to be re-executed.Vlastimil Brecka
07/06/2023, 6:45 PMVampire
07/06/2023, 6:45 PMVlastimil Brecka
07/06/2023, 6:49 PMVlastimil Brecka
07/06/2023, 6:50 PMVampire
07/06/2023, 6:52 PMalright great, time to migrate thenNot that you got me wrong, CC will not be reused if the TOML changes. But you still save time for the actual configuration that is necessary then.
Vampire
07/06/2023, 6:53 PMbtw where should I keep api url, and other non version constants if ext is icky?Depends on where you need them. If you for example just need them within the same build script, just use local variables.
Vampire
07/06/2023, 6:53 PMgradle.properties, then you also have it available in all projects if neededVampire
07/06/2023, 6:53 PMVlastimil Brecka
07/06/2023, 6:54 PMVampire
07/06/2023, 6:57 PMVlastimil Brecka
07/06/2023, 6:57 PMVlastimil Brecka
07/06/2023, 6:58 PMVampire
07/06/2023, 6:59 PMext but that does not make it any cleaner. 😄
It is usually just a work-around for not making it in some proper way.
Or as I said, often even an even simpler local variable would be more appropriate, but ill examples are out there.Vampire
07/06/2023, 7:00 PMwould you really put api urls in gradle.properties? that always felt like a place for constants plugins use, not "application" stuffAs I said, depends. If I need it in multiple build scripts, probably. If I just need it in one, I might more use a local variable. But probably also depends on mood. 😄
Vlastimil Brecka
07/06/2023, 7:04 PMVampire
07/06/2023, 7:06 PMVlastimil Brecka
07/06/2023, 7:10 PMChris Lee
07/06/2023, 7:16 PMVlastimil Brecka
07/06/2023, 7:21 PMChris Lee
07/06/2023, 7:21 PMVlastimil Brecka
07/06/2023, 7:21 PMChris Lee
07/06/2023, 7:22 PMVlastimil Brecka
07/06/2023, 7:22 PMChris Lee
07/06/2023, 7:23 PMChris Lee
07/06/2023, 7:24 PMgradle-build-action (and turn on the Gradle build cache) to benefit there as well.Vlastimil Brecka
07/06/2023, 7:24 PMVampire
07/06/2023, 7:24 PMVlastimil Brecka
07/06/2023, 7:24 PMVampire
07/06/2023, 7:24 PMVampire
07/06/2023, 7:24 PMVlastimil Brecka
07/06/2023, 7:25 PMVampire
07/06/2023, 7:26 PMChris Lee
07/06/2023, 7:26 PMVampire
07/06/2023, 7:26 PMVampire
07/06/2023, 7:26 PMVlastimil Brecka
07/06/2023, 7:26 PMChris Lee
07/06/2023, 7:27 PMVampire
07/06/2023, 7:27 PMclean to get halfway correct builds. 😄Chris Lee
07/06/2023, 7:28 PMVampire
07/06/2023, 7:28 PMVampire
07/06/2023, 7:28 PMChris Lee
07/06/2023, 7:29 PM