hi!👋 @Oleg Nenashev

Morning

hi！

Just looking at the repositories. I see you converted the class from Groovy to Kotlin. Have there been any other updates?

Yes, I have converted CheckstyleInvoker to Java, but I have run into new problems: some of the integration tests are failing, and I am trying to resolve them.

In github.com/JayWei1215/checkstyle/pull/10 , right? Any help needed?

I'll put it aside for now and try to solve it myself.

Another question is that I am not sure what test cases there are. Does the original repository's test cases cover all scenarios?

I doubt that, but they do cover some. My suggestion would be to focus on having the operational skeleton of the project - buildable main branch with working tests and CI. Without that, developing new tests or functionality hardly makes much sense

Yes, I aggre.

hi! @Oleg Nenashev The test "adds checkstyle tasks to check lifecycle task" did not pass, and here is the detailed error message: Condition not satisfied: project.tasks.named('check').get().dependsOn.contains(checkstyleTask) | | | | | | | | | | | | false task ':checkstyleMain' | | | | [org.gradle.internal.AbstractCodeQualityPlugin$7$1@7ade0d77] | | | task ':check' | | provider(task 'check', class org.gradle.api.DefaultTask) | [task ':assemble', task ':build', task ':buildDependents', task ':buildNeeded', task ':check', task ':checkstyleMain', task ':checkstyleOther', task ':checkstyleTest', task ':classes', task ':clean', task ':compileJava', task ':compileOtherJava', task ':compileTestJava', task ':otherClasses', task ':processOtherResources', task ':processResources', task ':processTestResources', task ':testClasses'] root project 'test' I have tried for a long time but still cannot solve it. According to the error message, it seems that checkstyleMain, checkstyleTest, and checkstyleOther have already been created.

@Jay Hi. Could you please summarize the updates since Saturday?

@Oleg Nenashev Hi. I have separated the fixture and written the first integration test,

CheckstylePluginClasspathIntegrationTest

, but an exception was thrown: 1: Task failed with an exception. ----------- * What went wrong: Execution failed for task 'clientcheckstyleMain'.

A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction

com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask

Hi @Jay are you around? Or do we move the sync?

Hi, I rewrote the

CheckstylePluginClasspathIntegrationTest

in `CheckstylePluginClasspathIntegrationNewTest`using the Spock framework instead of using the test fixture, and the same error occurred: org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /var/folders/f1/423wnzw536z9s0c6mfhb24300000gn/T/spock_accepts_throwing_ex_0_testProjectDir6921357308565921104 with arguments [checkstyleMain] Output:

Task apicompileJava

Task apicompileGroovy NO-SOURCE

Task apiprocessResources NO-SOURCE

Task apiclasses

Task apijar

Task clientcompileJava

Task clientcompileGroovy NO-SOURCE

Task clientprocessResources NO-SOURCE

Task clientclasses

Task apicheckstyleMain FAILED

Task clientcheckstyleMain FAILED

FAILURE: Build completed with 2 failures. 1: Task failed with an exception. ----------- * What went wrong: Execution failed for task 'apicheckstyleMain'.

A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction

> com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask

@Jay you didn't schedule a sync for today, right? How is it going overall?

Sorry, I just recovered and will go out tomorrow, so the sync meeting may need to be postponed to next Monday, I will provide my updates as soon as possible.

@Oleg Nenashev Hi! Sorry for not noticing the messages on the GSoC channel, so I didn't summarize the progress in time.

@Oleg Nenashev Hi! I have completed the integration tests and added workflows. Should I close this PR now?https://github.com/JayWei1215/checkstyle-plugin/pull/10

Hi. Oleg

Are you joining the call @Jay?

Hi! Oleg. This is the PPT I made this morning. In the 'learning' section, I presented the possible features for the next development stage. Of course, these are just my personal ideas, and I'm not sure if they will contribute to the community. Can you give me some suggestions? @Oleg Nenashev

@Jay to summarize the discussion this morning, the proposal is to regroup and to discuss a single feature that could be implemented for the Checkstyle plugin, approximately within a 60 hours scope for the full implementation (code, test coverage, documentation, etc.) As it was expected, the CI pipeline didn't complete, so for now this item is incomplete, and I am not sure it worth to proceed with detaching, unless it can be finished in a week (up to a release). https://github.com/JayWei1215/checkstyle-plugin/actions/runs/9888789936/job/27313468363

Thank you for your suggestion. Although I really wanted to continue with the detachment, I am concerned that if we follow the original plan to detach the plugin, we might not complete the project. Therefore, I have decided to accept the suggestion to develop new features on the existing Checkstyle plugin. Despite the failure in detachment, I have learned a lot in the first phase.

I apologize for the project delay caused by some personal reasons.😔

For the new features, my idea is this: the old version of the plugin only supports configuring a small subset of Checkstyle features in the build file. When I want to set more advanced features, I need to add them to the configuration file, which, as shown in the PPT, has relatively complex syntax and can result in a poor user experience. Therefore, I want to add some commonly used features to the Checkstyle extension, allowing users to configure them directly in the build file through the Checkstyle block, making it more convenient to use.

However, next week I can work on both detaching the plugin and developing the new features simultaneously. If the detachment is still not completed by the end of next week, I will focus solely on developing the new features in the original plugin.

Hey! Fellow Gradle user (and past Google Code-in participant 😅) here. I just learned that Checkstyle plugin is being worked on in this year's GSOC – awesome to hear that! If time allows and you agree, I'd like to ask if some attention could be given to this issue. IMHO it'd significantly lower the barrier to starting using checkstyle for new users:)

@Jay as a reminder, you haven't yet shared access to the video you tried to play during the presentation. So that I didn't share heads up about the system audio, I was sure you're going to do the live demo & the video is just a backup