https://frum.finance logo
Join Slack
Powered by
<@U08QX3AF5RD> <@U04EQ1L14HG> we good to go on the...
# software-contributors
f
@ripe-lifeguard-67276 @mysterious-tomato-10057 we good to go on the frontend? Day 2 thread 🙂
m
Am I good to redeploy the preview so i can make comments again?
it didn’t work last night
r
Yeah I just pushed the most recent commit
free to redeploy
Pushed again. Users should be able to go through the onboarding flow or to skip it altogether.
👍 1
There are unaddressed claude comments because onboarding is static - meaning no api calls are made. There are a few components with commented out code that essentially do nothing at the moment but will be relevant once the auth api is integrated in a future pr. So anything to do with that I didn't address.
👍 1
m
i had some issues and commented screenshots
r
I fixed the onboarding sign in page
m
i had issues after your changes
r
oh i see them now.
yeah the sign in with slack is because of an api url - i was told to use api.frum.finance url for production, the working changes are currently on alpha, as to my understanding
so that works for me in development
ill fix the error page
m
@full-wall-37598 can we make it work for the preview server ? it will be *glistening-khapse-e11bfd.netlify.app
with some prefix
f
for cors we can’t do it I think
wildcards aren’t supported when doing cross domain cookie
it’s for security
after the frontend is deployed - I will need to iron out all the cors issues and configs, it’s working now for alpha I think
app.alpha.frum.finance should work
m
hmm so how do i test out this deployment on the previous server
f
would be hard if it’s not static
m
the number changes based on the pr number
r
whatsapp group link added
f
what about using the alpha domain? No way to connect it?
m
trying
f
@mysterious-tomato-10057 if you want to see it for yourself maybe just locally run npm run dev on the branch?
since it’s setup to use alpha for localhost
should in theory just work no? @ripe-lifeguard-67276
m
when i click login it sends me to here https://app.alpha.frum.finance/user/report
f
right
that’s from the cdk
frontend url
m
gotcha so no way to test lol
f
want me to change it to that for alpha?
we can just make https://alpha.preview.app.frum.finance/login the alpha url
m
well no bc there is a difference between alpha and a branch preview
f
right
so yeah no we need to manually set cors to exact domain name and protocol
so that is will save the cookie cross domain
m
but we have a fixed url now
but the backend doesn’t know about it basically
f
right
actually
wait yeah no way…
m
okay i guess i’ll just have a list of review comments once i can test in alpha
i’l focus on the code now and the experience later
✅ 1
seems busted
f
@ripe-lifeguard-67276 please check
r
corrected - i just added it to the error page in general
f
@mysterious-tomato-10057 we good now?
m
I really like my original UI/UX with the mock data, i’d like there to be a way to continue to access that (maybe a special route?) until we are able to achieve that end state, instead of just deleting or hiding the whole thing
hard for me to compare if i have no way to access my design
also since i can’t actually access the UI from my branch it feels kinda like a blind date haha
As claude points out, I am still seeing a lot of code to handle spend vs goal, which i still don’t understand why we have any of that on the frontend
claude notes no input validation as well
do you want to make tickets for the outstanding work so we can merge this so its more reviewable?
❤️ 1
f
Yeah tickets would be great
Input validation is on backend
m
it should be on both… no?
f
I think any mentions of goal are commented out or were already removed
I mean, we can add it but I do think it requires numbers only
On front end
m
does it?
f
Plus you should be able to access test data somehow
m
CleanShot 2025-07-15 at 14.58.58@2x.jpg
f
Let's deploy and check 😉
Or use localhost
You can use that
m
okay i have an idea
but we need to swap the urla round
around
f
Meaning?
m
alpha.app.frum.finance
will be the alpha branch deployment
we good now, just need to update the backend
anything on the 
alpha
branch will be at that url
master will be prod
so just update backend then i can check the website
f
It also needs to be hardcoded in the frontned since we're not using env var
m
understood, but then i can actually review the branch
r
Goal field should only be in the types and maps because due to the api response including them
m
makes sense
alhpa deployed, after logging in with slack i see this, is this right?
r
Yes!
Cheese is from the api...
m
shouldn't i see the household profile data ?
r
theres no fetchDemographics endpoint in the backend yet, so we can't show those details
m
is this from the backend?
r
yes, all numbers are from the backend
m
why i scroll back to the month of may, i am unable to go back forward to june
r
except for the spend which you inputted
hm, that shouldnt happen
when i tested locally that wasn't happening
m
@full-wall-37598 how is the backend determining the averages currently if we don't have enough alpha users to createa. cohort?
no previous or next buttons
r
which deployment link are you on?
m
r
yeah the prev next buttons are a part of the insights component
because aprils budgets weren't finalized yet, ui requests for input
m
right but you see the issue right?
r
after submission, it will be able to navigate
m
right but i don't want to submit april, so now i'm stuck
r
ah okay ill move it
m
👍
r
ok just pushed
I addressed claudes comments as well for clarity
Open in Slack
PreviousNext
Powered by