I made a pull request in the slackapp repo with a ...
# software-contributors
c
I made a pull request in the slackapp repo with a few simple changes including a devcontainer and upgraded
deploy.sh
script. As soon as its approved I'd love to continue working on the slack admin lambda.
m
link?
c
m
can you separate the dev container stuff into a separate PR? I don't understand it enough and want zier to approve that but i can approve the rest. I was under the impression that the slack app was already nested inside the core dev container
c
separate PR
sure
I was under the impression that the slack app was already nested inside the core dev container
Oh perhaps, I'm not sure. I only really created it because it's the only functional way for me to build on windows.
m
πŸ‘
i can’t relate to your pain, i am on a mac
πŸ˜€ 1
i was able to use the slack app repo from my core remote dev container on gitpod
without and changes
just had to go up a directory and see the slack app was already there
c
i was able to use the slack app repo from my core remote dev container on gitpod
Oh ok good to know. (I still prefer not use gitpod unless we get localstack working, because without localstack its just an extra tool to use for no good reason)
m
πŸ‘
c
anyways, im gonna figure out how to separate this pr
m
i totally agree, i prefer to build locally
and you can use localstack just fine without gitpod anyway
so even then i don't see a use case
i think zier just had people with weak laptops
πŸ‘ 1
it could be helpful also to save battery life
c
Ok I updated the PR
m
approved
c
yay! (btw whats the rule with prs? Am I supposed to close it or let you do it?) (ive never worked with others in git thats why im asking)
m
once i approve it, you can merge whenever you are ready for it to go out and deploy, then just watch to make sure the pipeline doesn't break or something bc of your change.
πŸ‘ 1