:wave: Hi! I'd like to request a review of <https:...
# fluent-bit
c
p
Hmmm, looks like the CI didn't fire - usually a Github Actions issue. Can you rebase/force-push so it triggers it again?
👍 1
🫶 1
I recall another PR about getting some more codeowners for the Azure plugins so it's not all on the default ones, let me see if I can find it so can tag the appropriate people from that.
c
Sorry, just saw this. I force-pushed and workflows are now awaiting approval.
p
I've approved it
Usually someone does when they go through - for obvious supply chain security reasons that are very important right now we cannot just run any PR from anyone
👍 1
c
Thanks. Will I also need a review from the global codeowners? https://github.com/fluent/fluent-bit/blob/master/CODEOWNERS#L12
p
Yeah, code owner is required before merge otherwise any random person like me can just approve it 😄
😀 1
c
@eduardo Sorry, could you review? Is there a process for requesting a review?
p
It will be in the pipeline but there's a few so may take a while - plus it's holiday season in lots of the world too
c
Thanks Pat. Did it enter the pipeline effectively when you approved?
p
I think Eduardo will be working his way through, if CI isn't green though it'll be skipped so just double check that
c
Thanks
p
Can you add a unit test btw? That'll help prove it works and prevent any regression in the future.