<https://github.com/fluent/fluent-bit/pull/10990> ...
# fluent-bit
r
https://github.com/fluent/fluent-bit/pull/10990
Copy code
Hey, the merge into prod_v1.0.2 had an incomplete conflict resolution in `send_batch_with_count` (oci_logan.c) which broke all CI checks. I've reverted oci_logan.c to the previous working version for now, can someone take a look at the merge conflict properly? Also, any idea on the timeline for when this can be merged?
@eduardo @Pat
p
I suspect it'll be in the queue for Eduardo but last week was busy with Kubecon and 5.0 releases after the various Github supply chain issues as well (e.g. the Trivy incident). You may need to wait a bit now that the 5.0 release is out for people to catch up with reviews.
I cannot approve it as not an area I am code owner of I'm afraid. Saying that it looks like the Oracle plugins do not have code owners associated so are defaulting to the general ones - it may be a good idea to get the relevant code owners assigned for this to speed up reviews of specific plugins @reda ghouzraf. I'm not sure who or if anyone wants to volunteer though.
r
Thank you, that makes sense, we're from the Oracle team and would be happy to volunteer as code owners for the Oracle plugin. Could you point us to the right process for getting that set up?
@Pat is it just a matter of opening a PR to update the CODEOWNERS file
p
Yes, send a PR. Note you will be responsible for ensuring contribution matches the style guide, etc. as well as everything specific to the actual technical side.
r
hey, @Pat
just to confirm the pr should be like this https://github.com/fluent/fluent-bit/pull/11657
p
Yeah looks right although I'd add something to the description to explain it a bit and also make sure everyone involved is happy to be a code owner.
✅ 1
r
Thanks, I've already checked with the others and they’re all fine with being listed
i've updated the description as well