https://linen.dev logo
Join Slack
Powered by
Ok - here is a draft PR of the v4 re-factor: <htt...
# fluent-operator
j
Ok - here is a draft PR of the v4 re-factor: https://github.com/fluent/fluent-operator/pull/1869
Comments welcome.
@Steve Hipwell when you get a moment, any thoughts or suggestions on https://github.com/fluent/fluent-operator/pull/1869?
and @Marco Franssen
s
@Josh Baird I'm just finishing up for the day but I'll take a quick look tomorrow.
j
no rush, thanks
m
Sorry was off for few days this week. Will try check early next week
d
Sorry for jumping into this long running debate, I have been following the crd discussion for the helm chart on github and am looking forward to whatever new path is chosen. I tend to agree with @Steve Hipwell that a second crd chart is probably not needed at all. With the crds folder as our source of truth, all workflows should still be supported. @Marco Franssen you should still be able to deploy CRDs separately from the chart by just creating an ArgoCD app that points only at the CRDs directory. You could even choose to just install fluentbit/fluentd crds with a wildcard. Having unused fluentbit/fluend CRDs in the cluster doesn't sound like a huge concern to me (as someone who only uses fluentbit), and users who have limitations that would only want one set of CRDs can surely find a way to install only the ones they want. Either way, I looked over your PR @Josh Baird and think it looks good as far as having a separate crd chart implementation goes.
👍 2
j
@Dylan Jenik I really appreciate the input and that you took a look at the PR.
I'd like to get a v4 release of the helm chart soon since we're also looking at another fluent-operator release in the next few days.
👍 1
m
Sorry for my absence lately. To much other prios. I'll try the new 4.0 in whatever shape once it is there
👍 1
j
No worries -- we're all busy.
I'll try to spend some time today getting the PR ready for official review.
@Steve Hipwell still interested in your feedback if/when you have some spare cycles!
s
Sorry, I'm busy but will look at it.
👍 1
j
@Steve Hipwell Thanks for the comments -- pushed a few commits to address your concerns. Regarding the README templating -- are you suggesting that instead of maintaining our own templates, we instead use the global template in fluent/helm-charts?
s
Yeah, you'll need to use the global template to be able to release otherwise there will be a perpetual diff. If you need more customization let me know and I can update the template to support additional sections.
j
Yeah - I think we'll need a little more customization.. I'll look and let you know.
👍 1
We currently have detailed installation instructions (simple method, advanced method using crds chart) and upgrading instructions as well. I suppose we could either pull that out into separate sections or into separate files all together. If we split into separate files, it would still be handy to link from the main README though.
I guess we could shove this stuff into extraDocs.
s
I'd start with 
extra.docs
and then we can see if there needs to be more customization added.
👍 1
j
Ok - I think https://github.com/fluent/fluent-operator/pull/1869 is ready for another review @Steve Hipwell @Marco Franssen
5 Views
Open in Slack
PreviousNext
Powered by