My first Fluent Bit code PR ready for review: <htt...
# fluent-bite
Eric D. Schabell
11/21/2025, 9:52 AMMy first Fluent Bit code PR ready for review: https://github.com/fluent/fluent-bit/pull/11192
🙌 2
p
Pat
11/21/2025, 10:41 AMLooks good, frustrating those were not flagged in review - that's what AI is for! 🙂
Can you backport as well?
e
Eric D. Schabell
11/21/2025, 10:56 AMTo what?
p
Pat
11/21/2025, 11:48 AM4.0 and 4.1 ideally, should be an easy cherrypick
e
Eric D. Schabell
11/21/2025, 11:49 AMWould that be in the same PR?
Eric D. Schabell
11/21/2025, 11:50 AMI’ve not done “back porting” here before… guidance?
p
Pat
11/21/2025, 11:50 AMNo, PRs are per branch so you have to create another for each backport.
e
Eric D. Schabell
11/21/2025, 11:50 AMThat I can do….
p
Pat
11/21/2025, 11:51 AM Copy code
git checkout 4.0
git pull
git checkout -b backport
<copy changes>
git commit && git push
<create PR but ensure to target 4.0 base>e
Eric D. Schabell
11/21/2025, 11:51 AMyep, that’s what I was gonna ask… that workflow….
p
Pat
11/21/2025, 11:51 AMrepeat for 4.1
e
Eric D. Schabell
11/21/2025, 11:51 AMPerfect. Will do but not today.
p
Pat
11/21/2025, 11:51 AMmake sure when you create the PR it does not target
mastere
Eric D. Schabell
11/21/2025, 11:52 AMOr let me see how fast I can do one….
Eric D. Schabell
11/21/2025, 11:52 AMYes, good point on the PR target
p
Pat
11/21/2025, 11:52 AMit depends on what changes are also in the same file for
master Copy code
git checkout <PR branch> -- <file>e
Eric D. Schabell
11/21/2025, 11:54 AMWhoops, my fork only has master
Eric D. Schabell
11/21/2025, 12:26 PMBackporting to 4.1: https://github.com/fluent/fluent-bit/pull/11194
Eric D. Schabell
11/21/2025, 12:38 PMBackporting to 4.01: https://github.com/fluent/fluent-bit/pull/11195
p
Pat
11/21/2025, 12:53 PMThe PR titles are wrong but I can fix that and merge
e
Eric D. Schabell
11/21/2025, 12:58 PMOh, didn’t know that was how you do the titles,thanks!