Hi there! I've setup a PR to add a new `out_logrot...
# fluent-bit
s
Hi there! I've setup a PR to add a new
out_logrotate
plugin to fluent-bit. It is generally based on the
out_file
code with extra steps. patrick-stephens started reviewing but it seems tests are failing on Windows. Any idea how to progress the PR so it can be merged? https://github.com/fluent/fluent-bit/pull/10824
p
It looks like builds are failing on most targets, normally this means missing dependencies or using something unsupported on specific targets.
Should it work for WIndows? If not disable it for that target.
You can do the builds locally to check things more easily: • Linux:
./packaging/build.sh -d <distro>
There are other issues too highlighted in the CI, e.g. CentOS 7 has the usual incorrect syntax for failure:
Copy code
87.91 /src/plugins/out_logrotate/logrotate.c:800:9: error: 'for' loop initial declarations are only allowed in C99 mode
87.91          for (int j = i + 1; j < file_count; j++) {
You cannot declare variables as part of the loop definition for the C compiler available to vanilla CentOS 7. Note that this is also required for the coding standards: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#variable-definitions
I would suggest looking at the various build failures either in CI or repeating a build locally to see why. It looks to me like you need to tweak a few different things.
The OSS maintainers just do not have time to go through failing PRs unfortunately in any great detail, once it is green in CI then it can be reviewed.
s
Thank you for you suggestions! I'll try to fix these