Sagi Rosenthal
10/28/2025, 8:13 AMout_logrotate plugin to fluent-bit. It is generally based on the out_file code with extra steps.
patrick-stephens started reviewing but it seems tests are failing on Windows.
Any idea how to progress the PR so it can be merged?
https://github.com/fluent/fluent-bit/pull/10824Pat
10/28/2025, 10:43 AMPat
10/28/2025, 10:43 AMPat
10/28/2025, 10:46 AM./packaging/build.sh -d <distro>Pat
10/28/2025, 10:48 AM87.91 /src/plugins/out_logrotate/logrotate.c:800:9: error: 'for' loop initial declarations are only allowed in C99 mode
87.91 for (int j = i + 1; j < file_count; j++) {
You cannot declare variables as part of the loop definition for the C compiler available to vanilla CentOS 7.
Note that this is also required for the coding standards: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#variable-definitionsPat
10/28/2025, 10:50 AMPat
10/28/2025, 10:51 AMSagi Rosenthal
10/28/2025, 1:56 PM