Hey team Can someone review this PR <https://githu...
# fluent-bit
r
Hey team Can someone review this PR https://github.com/fluent/fluent-bit/pull/10990
p
It'll be in the queue but you need to update to match the contribution guide and follow the PR template too.
r
should be good now, also theres a job that failed i dont know if i should update the branch again or just leave it, since it failed with a timeout
Can anyone of the reviewers check changes
p
It'll be in the queue so just be patient, it looks like CodeRabbit has flagged some legitimate concerns as well you may want to look at
r
ah i see, i resolved those related to either memory or have logic issue, you can check commit logs inside that message
p
maybe add a comment to the PR around them then, I wouldn't be checking inside commit logs 🙂
r
yeah true, ill do that
one question between each release is there a defined period of time like 2 weeks? or its based on changes
p
There's no regular cadence, generally it'll be down to required changes or bug fixes and then major releases are on the roadmap
✅ 1
For our downstream version we do weekly releases: https://github.com/FluentDo/agent This is to pick up dependency updates too
✅ 1
r
noted, thanks
p
There are nightly builds though of OSS available too
✅ 1
r
Hi, just a quick follow--up, is it fine for this PR to stay open without updates? I've seen some inactive PRs get closed, so i want to confirm it's still in the queue?
p
Yup
r
thanks
hey, is there any update on this