```hello everyone i'm trying to do a pr, for now i...
# fluent-bit
r
Copy code
hello everyone i'm trying to do a pr, for now it's only to the main branch of my forked repository of fluent-bit, but some jobs are failing like pr-compile-centos-7 is failing because of a missing dependency(cJSON.h is not found during compilation),
my question is should i look for workaround, or i should ignore error?
p
No, we have to support CentOS 7 so if it fails to build we cannot merge.
It sounds like you need to add the missing development dependency to both the packaging container and the PR test container
We have a dedicated PR build test just for CentOS 7 because it uses an older C syntax that trips people up often
r
Hello, its fixed now, i switched to jsmn but i got another issue on centos7. im getting the following errors:
Copy code
undefined reference to ASN1_STRING_get0_data  
undefined reference to EVP_MD_CTX_new  
undefined reference to EVP_MD_CTX_free
these are from a newer version of openssl, and the older equivalents are mostly deprecated. what should i do in this case, should i update to a newer version of openssl, or should i update my code instead?
p
Are you building using the documented approach above or manually building? Follow what the containers do
r
manually building
so i should use older equivalence of those functions? even are deprecated in newer version
its fixed now i added openssl 1.0.2 compatibility using ifdef checks for openssl version
p
sure - you can't just pull a new version of a dependency unless that dependency is available on the target, e.g. if you update to OpenSSL 3 how would folks using vanilla CentOS 7 get it? Commercially I've switched to static builds of OpenSSL for some of these older targets rather than OS packages but that's a whole separate issue 🙂 Using EOL OS makes things harder for everyone 😄
r
Ah, true, got your point.im not sure if there are any real downsides to using deprecated openssl functions besides possible performance concerns, but yeah i got your point .thanks
p
You would have to look at why they're deprecated really, ultimately we do support OpenSSL 3 but also have to support the older targets too so it's tricky
r
thanks will do