hey team, did something change with the "--disable...
# community-support
j
hey team, did something change with the "--disable-samples=TRUE" argument for edr monitor with the new update? we suddenly get Test results sample again in the alerts, which do not comply with our GDPR 😕 is there a new solution how to exclude them?
i
Hey @Julia Masche, TY for raising that up! I am checking, and will update once I'll have an answer 🙂
🙌 1
Hey @Julia Masche, there is a bug there in elementary 0.14.X and I created a fix for it 🙏 Once it is merged I will provide a guide on how to install the fixed version (until the next release).
j
Hey @Idan Shavit thank you so much 🙌🏻 one more question: I also noticed that the alerts are being sent out twice. Are you aware of that already?
i
Hey @Julia Masche, we are not aware of a duplicate alerts issue 🤔 Can you tell me on which kind of alerts this is happening to you? (tests/models/source freshness/all) Can I ask if you see the duplicate alerts on the table
alerts_v2
?
In addition we merged the fix 🙂 Until the release of the new version of the CLI, you can install elementary with the fix using the commit hash:
pip install git+<https://github.com/elementary-data/elementary.git@43b7fb5e8cff4bd9acbf7b7f9e36b906dc12e58f>
Just make sure that you run
pip uninstall elementary-data
before 🙂
thankyou 1
j
hey @Idan Shavit, for now only for tests 🙂 And yes, I can also see duplicate alerts on the table
alerts_v2
, e.g.
i
Interesting 🤔 Can I ask you to check if you have duplicate rows on your
dbt_tests
table as well? It will help me understand where should I research 🙏
j
I couldn't find duplicates there, no 🙂
i
Thanks for the info! One more question (hopefully the last) - Do you run multiple
edr monitor
commands at the same time?
j
sure no worries. we do indeed 🙂 but for different departments, so there is no intersection in terms of tests or models.
i
Got it thanks! So I think that this is the issue 🙂 The way our alerts are working is: 1. We populate the alerts_v2 table from all of the artifacts elementary package has collected 2. We filter the relevant alerts according to the
filters
argument 3. We send the alerts Because you are running
edr monitor
at the same time, both of the runs have the same state where the new alerts do not exist, so both create them - which it is what creates the duplication. If you'll run the
edr monitor
commands one after the other, it will stop creating the duplicate rows at the alerts_v2 table 🙂
We will think of a way to prevent this case and support multiple runs at the same time, but this could take a bit - so if possible I suggest to run them one after the other for now 🙂
j
ok understood 🙂 thank you @Idan Shavit for the help and explanation 🙌
🙏 1