Hi! Is there a plan for a new daft-lance release? ...
# daft-dev
f
Hi! Is there a plan for a new daft-lance release? 0.4.0 went out on June 5, and main has 11 unreleased commits since — Lance Namespace support (#35), atomic insert_overwrite (#62), segmented bitmap indexes (#31), plus several merge fast-path correctness fixes (#44, #45, #46, #56, #60). Since daft's lance extra tracks the latest daft-lance, none of this reaches daft users until a release is cut. If maintainers are short on time, I'm happy to help — I can open the release PR (version bump + changelog) so all that's left is publishing the GitHub Release. Just ping me for whatever else is needed.
r
Thanks for this. If you would please open the PR, I can help release tomorrow morning.
f
github.com/daft-engine/daft-lance/pull/68 propose a release PR, please take a look, thx
r
Thanks! It's available - pypi.org/project/daft-lance/0.5.0
🙌 1
f
Thanks!
github.com/Eventual-Inc/Daft/pull/7512 this is a following PR in daft which focus on upgrade
daft-lance
, plan to split another PR to support other features like lance namespace, could you help to review this upgrade PR first?
👍 1
github.com/Eventual-Inc/Daft/pull/7518 This is the second PR which add lance namespace in daft side
r
Approved, thanks for the Lance PR's!
f
Thanks a lot for reviewing and merging the PRs! The
daft-lance
version upgrade is basically done now. There is one remaining issue I’d like to get the your thoughts on: the
merge
mode in
write_lance
. The implementation semantics of
merge
were not very clear(mixed with create, append, merge), and exposes quite a few Lance-specific details at the Daft layer. There are also some corner cases that make the behavior harder to define and maintain consistently. I’m wondering whether it would make sense to deprecate
mode="merge"
in
write_lance
and instead let users use the merge APIs provided directly by the
daft-lance
package, e.g.
merge_columns
, for this kind of operation. What do you think?
r
That sounds reasonable, would you like to deprecate "merge"?
f
github.com/Eventual-Inc/Daft/pull/7526 The PR is merged by @srilman