VOID 001
11/06/2025, 3:51 AMSrinivas Lade
11/06/2025, 9:39 PMSrinivas Lade
11/06/2025, 9:47 PMVOID 001
11/08/2025, 5:14 AMVOID 001
11/10/2025, 4:48 AMVOID 001
11/16/2025, 2:21 PMVOID 001
11/16/2025, 3:02 PMmake precommit, it shows common-metrics cannot pass compile, but I can do make build without any error. The message indicates that "pyclass" attr not found
error: cannot find attribute `pyclass` in this scope
--> src/common/metrics/src/lib.rs:27:3
|
27 | #[pyclass(module = "daft.daft", eq)]
| ^^^^^^^
error: could not compile `common-metrics` (lib) due to 1 previous errorColin Ho
11/19/2025, 3:01 AMColin Ho
11/19/2025, 3:03 AMI also have a question, when I runPyo3 is a default feature in the project, and when we run checks we run with and without it. You probably need to add, it shows common-metrics cannot pass compilemake precommit
#[cfg(feature = "python")] where appropriateVOID 001
11/19/2025, 3:38 AMVOID 001
11/19/2025, 3:38 AMVOID 001
11/19/2025, 8:37 AMColin Ho
11/19/2025, 8:41 AM