Hi <@U08RG6UAA0L> I am interested in implementing ...
# daft-dev
v
Hi @Srinivas Lade I am interested in implementing distributed flotilla daft dashboard in order to make it work on Ray cluster environment. Is there any suggestion or documentation/guide I can follow? Thanks BTW, I've checked the roadmap https://github.com/Eventual-Inc/Daft/discussions/5155 already, looking for some good starting point for the distributed version.
šŸ‘ 1
s
Hey @VOID 001, it's awesome to hear that you want to help with the distributed dashboard support! I updated the roadmap to track our current plan for the dashboard, but for context: • We are current focused on adding support for emitting metrics through OpenTelemetry (OTEL), as we know many users have existing metrics setups like Prometheus that they want to dump metrics into • In addition, we are working on taking Swordfish-level worker metrics and aggregating them on the Flotilla scheduler node for global metrics • Lastly, we are working on getting the subscriber framework, which the dashboard uses, working with Flotilla. That should enable the dashboard
There are a couple of loose ends that we currently need to deal with that I'd love some help with: • Right now, when a query fails or is canceled, the dashboard gets stuck. We should track the failed and canceled states and emit them to the dashboard • Once we aggregate metrics on the scheduler, we need to add some special handling for some operators. For example, with Filter, we compute a "selectivity" metric, which is the rows_in / rows_out. I've listed all operators that need special handling in the roadmap. It would be really helpful if you could take on some of them • We need to track the runner type (native vs distributed) for queries on the dashboard) If any of those sound interesting, let me know!
v
Sure! I would first take the issue "dashboard shows running forever when a query fails or canceled" and see how to fix it. Then discuss in further detail
šŸ‘ 1
Just submitted an issue for the daft-dashboard https://github.com/Eventual-Inc/Daft/issues/5518
šŸ‘ 1
Hi @Srinivas Lade, I tried to add "Canceled" and "Failed" state to the dashboard, it shows like this, does this look good to you? btw the draft PR is here: https://github.com/Eventual-Inc/Daft/pull/5576 You can take a look and provide some comments if you have time, I will clean it up recently
I also have a question, when I run
make precommit
, it shows common-metrics cannot pass compile, but I can do make build without any error. The message indicates that "pyclass" attr not found
Copy code
error: cannot find attribute `pyclass` in this scope
  --> src/common/metrics/src/lib.rs:27:3
   |
27 | #[pyclass(module = "daft.daft", eq)]
   |   ^^^^^^^

error: could not compile `common-metrics` (lib) due to 1 previous error
c
@VOID 001 srinu is out for next 2 week, I can help instead
I also have a question, when I run
make precommit
, it shows common-metrics cannot pass compile
Pyo3 is a default feature in the project, and when we run checks we run with and without it. You probably need to add
#[cfg(feature = "python")]
where appropriate
v
Thanks @Colin Ho! I have solved that problem "marked as *solved*" šŸ˜„
Could you please also take a look at my PR? link: https://github.com/Eventual-Inc/Daft/pull/5576
Kindly ping @Colin Ho just in case if you miss my message šŸ˜„ . https://github.com/Eventual-Inc/Daft/pull/5576 If you have time, could you please take a look at this PR, thanks
c
Yeah I saw, i'll take a look soon!
daft party 1