Hey folks, from what I tested, it's not possible t...
# troubleshoot
g
Hey folks, from what I tested, it's not possible to override Trino platform even though technically they have the platform config exposed on the configuration here https://datahubproject.io/docs/generated/ingestion/sources/trino/, right? From what I investigated, it seems to be overwritten by the way the platform get's passed upstream here https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/src/datahub/ingestion/source/sql/trino.py#L171 I was thinking about having a
Starburst
platform just to have the data a bit more user friendly here and wondering how we could do that... We tested overwriting the code to pass
starburst
as the platform parameter from the code default itself after creating the starburst platform and it worked, but not sure how we could collaborate with the datahub codebase to make it available... I'd guess the easier way it's having a
StarburstSource
that would extend the
TrinoSource
and do nothing but change that parameter... but I'm not sure it's a good idea! Thoughts?! c.c @best-notebook-58252
plus1 2
d
I think, currently that is the easiest way to change the platform name.
Is Trino that confusing?
g
I mean, personally for me it's not. But we've got users that are quite away from the platform and the name they know is Starburst, they have no idea what Trino is. Then it's a bit fishy so it'd be a nice quick user experience bump if we could change it. It was really easy to add the platform and logo but then 🤡
b
@green-hamburger-3800 So if you emit the "dataPlatformInfo" aspect for the data platform entity with urn:
urn:li:dataPlatform:trino
you should be able to use the "displayName" and "logoUrl" fields to customize this. The urn will still say urnlidataPlatform:trino but your users will not typically see that 🙂
You can also change the default data_platforms.json that we load into datahub (this file)
g
Hey, that hacky "edit the trino platform" idea is interesting eh 🤔 I'll throw the idea around here and see how it goes. Thanks a lot for the input, haven't thought about that