Hi Team, I added `get_entity_v2` to the python pac...
# contribute-code
w
Hi Team, I added
get_entity_v2
to the python package for your review. https://github.com/datahub-project/datahub/pull/5255 I realized that this API return datasetKey despite invalid urn requested.
{'status': None, 'dataPlatformInstance': None, 'datasetKey': DatasetKeyClass({'platform': 'urn:li:dataPlatform:presto-on-hive', 'name': 'idonotexist.jonsnowknowsomething', 'origin': 'PROD'})}
Is it suppose to behave like this? As
get_aspect_v2
return 404 after passing invalid urn. As this is my first time commiting to Datahub, please let me know if test is needed for this. I have done the lintFix .
o
The datasetKey being returned is expected, this is due to our support of "ghost nodes" in relationships (things that don't exist yet because they haven't been ingested). For the PR review @helpful-optician-78938 has been assigned and will take a look when he gets a chance πŸ™‚
w
Sure! Ty Ryan
b
Thanks @worried-branch-76677!!
teamwork 1
w
Any update for this small pr ? πŸ‘€
l
Hi @worried-branch-76677! Thanks for your patience here - we have this on our short-list of PRs to review & will move it through ASAP! We’re a bit short-staffed this week due to some folks taking some much deserved PTO πŸ™‚
πŸ™‡ 1