Would someone be able to look at my two small PRs ...
# contribute-codeb
brave-zebra-97479
11/15/2022, 6:44 PMWould someone be able to look at my two small PRs this week?
https://github.com/datahub-project/datahub/pull/6439
https://github.com/datahub-project/datahub/pull/6435
They are both passing all checks.
l
little-megabyte-1074
11/15/2022, 9:23 PM
Hi @brave-zebra-97479! Thanks for checking in — I’ll escalate these with the team today so we can get a reviewer assigned teamwork
b
big-carpet-38439
11/15/2022, 10:02 PMQuestion @brave-zebra-97479 - What is the motivation behind adding AWS modules as a build-time dependency for DH deployments?
b
brave-zebra-97479
11/15/2022, 10:06 PMIt's for supporting IAM auth for AWS MSK. Without the MSK IAM Jar file, the kafka-setup and datahub-upgrade jobs will fail.
brave-zebra-97479
11/15/2022, 10:07 PMFwiw, the MSK IAM modules are already a dependency in Datahub gradle builds. This just adds them to those two jobs.
brave-zebra-97479
11/15/2022, 10:08 PMWhat I am still confused about is how anyone was able to get it working before without these changes. I assume the dependency was added to the Gradle build in order to get it working in the past, but then how did others address the kafka-setup and datahub-upgrade jobs?
brave-zebra-97479
11/15/2022, 11:36 PMThinking about it some more, I'm wondering if it makes sense not to download it from Github for the Dockerfile. I can see not wanting to add another dependency. An alternative would maybe be to download the jar file and package it with Datahub?
5 Views