Hi <@U01JUBAPZPS>, <@UV0M2EB8Q>
For one of our bus...
# uic
creamy-thailand-75908
11/14/2022, 10:38 PMHi @green-football-43791, @mammoth-bear-12532
For one of our business use cases, we would like to display both the default Dataset name (DatasetProperties -> Name field) and its associated display name (EditableDatasetProperties -> Name field) in the Dataset summary page.
We would like to follow a priority order as described below in determining which name to display.
◦ When no display name (no EditableDatasetProperties' name field exists), display the DatasetProperties aspect's Name
▪︎ If there is no DatasetProperties aspect's Name, then display URN
◦ When display name exists (EditableDatasetProperties aspect's Name field exists), show both display & DatasetProperties aspect's Name.
◦ We would like to show them in the same dataset title section - beside each other, with display name displayed in the larger font size as today and the DatasetProperties aspect's Name displayed in a slightly smaller font - either below it or to its right.
◦ Please note that that display name will be editable for owners (PR #6171 for this was previously sent and is in review) while DatasetProperties Aspect name will not be editable from the UI.
▪︎ If there is no DatasetProperties aspect's Name, then display URN
Enclosing a sample screenshot of this would look like for your review. Would like to seek your thoughts and if the above is agreeable, we could work on implementing it at our end and submit another PR to upstream Datahub. Please advise. Please let me know if there are any questions. @rhythmic-agent-54913
b
big-carpet-38439
11/15/2022, 10:45 PMI think this makes sense! I reviewed this PR yesterday, btw!
r
ripe-eye-60209
11/17/2022, 1:21 PM@creamy-thailand-75908 Hi, nice contribution. May I ask how did you customized the tabs (added data products) in your tabs?
c
creamy-thailand-75908
11/17/2022, 6:08 PMThanks @big-carpet-38439. I reviewed your comments and responded to some of them as well. Please let me know your feedback and will update the PR accordingly.
As for the above suggestion to display the DatasetProperties' aspect's Name, we will work on a separate PR and get back to you. Thank you!
creamy-thailand-75908
11/17/2022, 6:10 PM@ripe-eye-60209 - Thanks! We extended the Tabs in this line (https://github.com/datahub-project/datahub/blob/master/datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx#L91) within Dataset entity to add additional tabs such as "Data Products" and created a component to render its functionality similar to how the other Dataset tabs are created today.
r
ripe-eye-60209
11/17/2022, 6:44 PM@creamy-thailand-75908 so in this case you end up publishing and maintaining your own custom datahub frontend docker image?
6 Views