What are the implications on making changes to CorpUserKey which is the key aspect of the Corp User entity. I basically want to add another field i.e. 'Employee number' to the key aspect. I know that adding another field to the key aspect will change its Urn and ldap source for ingestion but does it affect any other functionality?

Hi Pratick! Adding an optional field to CorpUserKey would be reasonable & possible to do, but know that existing CorpUsers would not have the employee id number

Did not know that it was possible to add an optional field to the key aspects. Thanks!

Note that it would mean diverging from DataHub's canonical model. A better way may be to use the "username" field of the key directly

I agree and thats why I was asking what are the implications of diverging from DataHub's canonical model?

The only issue would be if we change the key in the future in OSS then you can have messy conflicts.