Hey team, I am trying to introduce a new

BrowsableEntityType

and noticed other existing type has some variable called

FACET_FIELDS

like in

DashboardType

private static final Set<String> FACET_FIELDS = ImmutableSet.of("access", "tool");

@early-lamp-41924 ^

Hey. which part of the code are you referring to ^ ? We shouldn’t need FACET_FIELDS any more after no-code push last year!

oh, I am adding a new

BrowsableEntityType

I found the

FACET_FIELDS

in all other

BrowsableEntityType

like

DashboardType.java

private static final Set<String> FACET_FIELDS = ImmutableSet.of("access", "tool");

This needs a bit of cleanup 😞 but

oh, what should I do in order to support BrowsableEntityType?

oh no continue what you were doing

I copied the code from other Type, like

@Override
  public BrowseResults browse(@Nonnull List<String> path, @Nullable List<FacetFilterInput> filters, int start,
      int count, @Nonnull QueryContext context) throws Exception {
    final Map<String, String> facetFilters = ResolverUtils.buildFacetFilters(filters, FACET_FIELDS);
    final String pathStr = path.size() > 0 ? BROWSE_PATH_DELIMITER + String.join(BROWSE_PATH_DELIMITER, path) : "";
    final BrowseResult result =
        _entityClient.browse(DATA_DOC_ENTITY_NAME, pathStr, facetFilters, start, count, context.getAuthentication());
    return BrowseResultMapper.map(result);
  }

yeah just remove the facetFilters and put a Collections.emptyMap()

oh, cool