<@U01NN9CTQ01> a question in <https://github.com/l...
# contribute-codes
square-activity-64562
10/11/2021, 7:01 AM@early-lamp-41924 a question in https://github.com/linkedin/datahub/pull/3353 related to some recent changes
🙌 1
square-activity-64562
10/11/2021, 4:43 PM@early-lamp-41924 I wanted clarification regarding the four files which are generated but are not in gitignore. Is there any specific reason for them not being in
.gitignoresquare-activity-64562
10/11/2021, 4:44 PMGood to add them in
.gitignoree
early-lamp-41924
10/11/2021, 5:18 PMHmn thought we added the whole directory to .gitignore
early-lamp-41924
10/11/2021, 5:18 PMdouble checking
b
big-carpet-38439
10/11/2021, 5:18 PMSo long as they end up in the PyPi distribution we should be good to ignore
e
early-lamp-41924
10/11/2021, 5:19 PMearly-lamp-41924
10/11/2021, 5:20 PMAre you still seeing them after pulling latest?
s
square-activity-64562
10/11/2021, 6:10 PMI did see them this morning after codegen ran. Will check again why they are showing up
e
early-lamp-41924
10/11/2021, 6:13 PMTesting locally as well
early-lamp-41924
10/11/2021, 6:28 PMI do see them
early-lamp-41924
10/11/2021, 6:32 PMSeems like you need to end with / for directories
early-lamp-41924
10/11/2021, 6:32 PMearly-lamp-41924
10/11/2021, 9:25 PMvery weird
early-lamp-41924
10/11/2021, 9:25 PMeven after updating it is not ignoring
3 Views