hi for the PR above, should I move it to the linke...
# contribute-code
d
hi for the PR above, should I move it to the linkedin/datahub repo for it to get eyes on it?
s
The
acryldata/datahub
repository is used for CLI release purposes. No direct PRs are merged into it
d
got it, let me move it over then
@square-activity-64562 would you be able to look at this PR? https://github.com/linkedin/datahub/pull/4388
s
@damp-greece-27806 From the comments it looks like @mammoth-bear-12532 is already looking at the PR. I will defer to him. Ideally we would have compatibility tests else I am worried we will fix it for one version and break for another version of airflow that someone else is using.
d
yea - it’s just that the latest currently doesn’t work for any of the airflow 2.x installations because of the pinning. It has to go back all the way 0.8.17.1 to work
s
I understand this is not ideal. We really should have those compatibility tests so we can catch these in our CI. Even if I might be ok with that change I cannot merge it in. Only @mammoth-bear-12532 can merge it in currently. So we will have to wait for @mammoth-bear-12532. Thanks for your patience
d
ok perfect, thanks!
@mammoth-bear-12532 thanks for the approval on the PR! what are the next steps to get this launched?
m
@damp-greece-27806 I have merged it... next step would be cutting a pypi release