Hey all, looks like my PR has some failing build c...
# contribute-code
p
Hey all, looks like my PR has some failing build checks after pulling latest master: https://github.com/datahub-project/datahub/pull/4441/ I'm also seeing some mypy failures in the build, but everything is green when I run it locally. Is there some weird caching or something going on?
d
I reran the failing checks and let’s see what will happen
p
πŸ™
Looks like its still failing πŸ˜•
d
it is failing with the following mypy errors:
Copy code
src/datahub/ingestion/source/usage/bigquery_usage.py:646: error: Incompatible types in assignment (expression has type "List[google.cloud.logging_v2.client.Client]", variable has type "List[google.cloud.bigquery.client.Client]")
src/datahub/ingestion/source/usage/bigquery_usage.py:648: error: Argument 1 to "_get_bigquery_log_entries_via_gcp_logging" of "BigQueryUsageSource" has incompatible type "List[google.cloud.bigquery.client.Client]"; expected "List[google.cloud.logging_v2.client.Client]"
p
Yeah, but I'm not getting that when I run mypy locally It also doesn't make sense looking at the code:
Copy code
if self.config.use_exported_bigquery_audit_metadata:
            clients = self._make_bigquery_clients()
            bigquery_log_entries = (
                self._get_bigquery_log_entries_via_exported_bigquery_audit_metadata(
                    clients
                )
            )
            parsed_bigquery_log_events = self._parse_exported_bigquery_audit_metadata(
                bigquery_log_entries
            )
        else:
            clients = self._make_bigquery_logging_clients()
            bigquery_log_entries = self._get_bigquery_log_entries_via_gcp_logging(
                clients
            )
            parsed_bigquery_log_events = self._parse_bigquery_log_entries(
                bigquery_log_entries
            )
Copy code
(metadata-ingestion) ➜  metadata-ingestion git:(bq-usage-use-bigquery-audit-logs) βœ— mypy src/datahub/ingestion/source/usage/bigquery_usage.py
Success: no issues found in 1 source file