Small PR to add possibility to ingest the redash m...
# contribute-codei
icy-piano-35127
04/08/2022, 12:37 AMSmall PR to add possibility to ingest the redash metadata by filtering it passing a database option: https://github.com/datahub-project/datahub/pull/4616
b
big-carpet-38439
04/08/2022, 4:14 PMThanks Bruno !! We'll take a look
teamwork 1
big-carpet-38439
04/08/2022, 9:44 PM@icy-piano-35127 I left a few comments 🙂
i
icy-piano-35127
04/08/2022, 9:45 PMTY @big-carpet-38439
icy-piano-35127
04/08/2022, 10:16 PMI've done some modifications and answered your comments 🙂
b
big-carpet-38439
04/08/2022, 10:27 PMAmazing, thank you for the speedy turnaround!
teamwork 1
big-carpet-38439
04/08/2022, 10:29 PMApproved - running CI now. Once its green will go ahead and merge
i
icy-piano-35127
04/09/2022, 12:04 AM@big-carpet-38439 I'll run the black to fix the metadata-ingestion-general 3.9, seems like that the linter didn't like my code style hahaha 😞
b
big-carpet-38439
04/09/2022, 12:05 AMOk wonderful - thanks!
catyay 1
i
icy-piano-35127
04/09/2022, 12:14 AMAwaiting approval to run the workflows
b
big-carpet-38439
04/11/2022, 3:59 PMRunning!
3 Views