Hi! Do we know what the fate of <DatasetProperties...
# ui
p
Hi! Do we know what the fate of DatasetPropertiesContainer will be? I see that it’s currently dead code.
b
@rhythmic-doctor-72391 @breezy-forest-52817 ^^^
r
What do you mean by dead code @plain-arm-6774?
It is a dynamic reference which is why it’s not directly coded in the template files
p
Ah, excuse my ignorance on frontend tech. The greater context is that I populated DatasetProperties aspect like this:
Copy code
'aspects': [('com.linkedin.pegasus2avro.dataset.DatasetProperties', {
                    'description': table.comment,
                    'customProperties': {
                        'dbEndpoint': database.endpoint,
                        'dbName': database.name,
                        'dbDescription': database.description,
                        'dbPublisher': database.publisher,
                        'dbContacts': ','.join(database.contacts),
                        'dbLdapReadGroup': database.ldap_read_group,
                        'dbLdapWriteGroup': database.ldap_write_group,
                        'dbComment': database.comment
                    }
                }),
and I expected to see them in the UI but didn’t. What tab does DatasetPropertiesContainer map to I only see:
I expected to see a “customProperties” section in the UI.
Thanks for the replies 👍
r
The "properties" container currently only deals with dataset deprecation
So I think it's more like a bad naming convention on our end, since that appears on the "Status" tab
In fact, looking at the code for the container it doesn't even call the properties aspect
p
Understood, any idea of whether showing customProperties in the UI is planned to be supported in the future?
r
Dug a little deeper, looks to me like we have some bits and pieces of code for it but there's currently no tab using said aspect
What we can do is bring this back to the team and work on prioritization for implementing this feature for open source
p
much appreciated, thanks!
@refined-fireman-13417 Should I create an issue for this for better tracking?
r
oh yeah, that'd be great. thanks 🙂
p