I'm making some tweaks to the datahub frontend and...
# ui
s
I'm making some tweaks to the datahub frontend and getting slightly confused about the view models... It looks like the search results view and the header on the dataset detail view both use
datahub-web/@datahub/data-models/addon/entity/dataset/dataset-entity.ts
This class has an
entity
property. In the search results view, this property is populated with the dataset, as expected. In the header on the dataset detail view, this property appears to be populated with an object containing a
dataset
property which as the actual dataset. This seems to violate the type annotation, and means that most of the getter properties fall back to null/empty values. I haven't changed anything about this page so I'm not sure why this property isn't being set correctly, or if this is expected and I'm missing something about how it works. Any advice from the front-end developers?
b
@breezy-forest-52817 @witty-hydrogen-79411 ^^^
w
Hi!
with header you mean
dataset-header.ts
?
ohh I get it...
Copy code
entity.dataset
?
that sounds familiar
there is some out of sync part in the midtier
@refined-fireman-13417 was working on this. Is this the latest build?
s
Yep, that's right. It looks like it goes awry in
data-models.ts
, or in
BaseEntity.readEntity
I'm a bit behind latest master. Let me try updating first...
w
it should include that one
s
Ah, yes, that definitely looks relevant.
Yep, that's resolved it. Thanks!
b
👍
w
Awesome!