Hi! We get a bit frustrated with the test run at b...
# ui
h
Hi! We get a bit frustrated with the test run at build time for the frontend when doing quick iterations, so we’re thinking about changing https://github.com/linkedin/datahub/blob/5a5c6863fa1918f2b27c2c0ee2359a3aa5fff62d/datahub-web/build.gradle#L51 into
task emberBuild(type: YarnTask, dependsOn: [execEmber, emberWorkspaceTest]) {
which would allow us to do
-x emberWorkspaceTest
when needed. Is this something the public repo would benefit from?
b
Thanks for raising this. We are aware of how long it takes to run the tests are actively working cutting down the time (kudos to @witty-hydrogen-79411). Meanwhile, I believe you can use
-x emberWorkspaceTest
to bypass the tests already without changing that specific line?
h
I have zero experience of gradle, so bare with me, but I ran into these kind of errors with the original task graph and disabled workspace tests
Copy code
> Task :datahub-web:emberBuild FAILED
yarn workspace v1.13.0
yarn run v1.13.0
$ ember build --environment=production --environment production
/bin/sh: 1: ember: not found
and didn’t find any trace of the
execEmber
-task being executed, so I concluded that the dependsOn change was needed.
(this was with code up until
f8f480b4c997d7963305d98e9acdda5a10c1ba60
)
and during the docker image build
b
Got it. @witty-hydrogen-79411 could you take a look at this? I vaguely remember seeing something similar in recent builds.
w
probably missing executing
yarn
step
taking a look at this script, seems that
execEmber
is not needed
but we do need to invoke
yarn
to download the dependencies in first place
w
This roundtrip time is truly annoying. I also got the same error Fredrik did when trying
-x emberWorkspaceTest.
Will try his hack for now. Have next to zero gradle experience as well.
7.5 -> 1.5 minutes. Thank you @high-hospital-85984
🤩 1