Would it make sense to change this line
<https://g...
# uic
calm-sunset-28996
04/14/2021, 12:13 PMWould it make sense to change this line
https://github.com/linkedin/datahub/blob/master/datahub-web-react/src/app/entity/dashboard/profile/DashboardHeader.tsx#L39
to
Copy code
photoUrl: owner.owner.editableInfo?.pictureLink || '', Copy code
Uncaught (in promise) TypeError: Cannot read property 'pictureLink' of nullcalm-sunset-28996
04/14/2021, 1:46 PMSo yeah, our ingested LDAP users don’t have pictures yet, nor have they editableInfo defined.
When I ingest dashboards with a hardcoded owner “datahub” everything works fine because these properties are defined on this specific user. But I guess this behaviour is suboptimal because we don’t want everything to crash if we don’t have pictures.
calm-sunset-28996
04/14/2021, 1:49 PM(I used the standard LDAP source to ingest our users.)
l
loud-island-88694
04/14/2021, 2:05 PM
@green-football-43791 ^ how does the recent change to default avatar picture intersect with this?
g
green-football-43791
04/14/2021, 3:58 PMthis should address that issue @calm-sunset-28996: https://github.com/linkedin/datahub/pull/2395
green-football-43791
04/14/2021, 3:58 PM@loud-island-88694 looks like this issue has been around before we added default icons to avatars: https://github.com/linkedin/datahub/pull/2379/files#diff-ca8e670e3a20bd4be1962e904cf18101e17d493d677b1a09731573dc2d839016L38
l
loud-island-88694
04/14/2021, 3:59 PM
good to know - thanks!
c
calm-sunset-28996
04/15/2021, 7:12 AMSuper, thanks for the swift action! 😄
2 Views