Our company is using keycloak as our identity prov...
# ui
g
Our company is using keycloak as our identity provider. I understand that datahub provide integration with keycloak for login. Will you be able to share how datahub handles logout with identity provider? From what I have seen in react-web module, a click on "logout" just trigger a function in "ManageAccount.tsx" to clear the cookie.
b
Yes we have no yet implemented callback logout with the IdP
I’m guessing you need this?
I think this is something that was overlooked in the first pass of impl. Please let us know if you need IdP login. We can either guide you or implement this ourselves.
g
Yes, we need it. We are thinking of implementing it first. It will be good if you can guide us. pac4j provide logoutcontroller and I think that it is something that I can take a look to implement the centralized logout with IdP
b
Yes I think we just need to make sure we have that on datahub-Frontend server (iirc it may already be there) and that we are making the call to it from the React app. Should be fairly straightforward
I can look into this a bit more tomorrow
g
are you referring to datahub-frontend/app/react/controllers/AuthenticationController? I think it is not there yet but it should be fairly easy to add them in. Just a few places to make the change like routes conf ,controller and react app
b
Yes that’s correct !
I can advise on this if you want to take a stab
g
hey john, we will proceed to make the changes for the logout.
b
Thanks junjie 🙂
Looking forward to it!
hi @glamorous-microphone-33484! How is this going... Please let me know if you need guidance or help with impl!
i see you raised a PR- wonderful!
g
Please ignore the PR first. Not intended to do a PR at the moment. Thanks!