white-beach-27328
05/17/2021, 5:35 PMtest-connection.yaml
files in the helm charts? I’m noticing that there are some odd bugs in them like:
• The gms test hitting a different endpoint than /health
which causes the service to 404 and fail (https://github.com/linkedin/datahub/blob/master/datahub-kubernetes/datahub/charts/datahub-gms/templates/tests/test-connection.yaml#L14)
• The mae consumer is expecting there is a service to provide dns resolution for the test: https://github.com/linkedin/datahub/blob/master/datahub-kubernetes/datahub/charts/datahub-mae-consumer/templates/tests/test-connection.yaml. No service exists.
• Similarly as above, the mce consumer is expecting there is a service to provide dns resolution for the test: https://github.com/linkedin/datahub/blob/master/datahub-kubernetes/datahub/charts/datahub-mce-consumer/templates/tests/test-connection.yaml#L14. No service exists.
I was initially going to submit a PR fixing this, but tbh I’m not seeing their value given that there are now readiness and liveliness probes on the different deployments which are effectively doing these tests anyway. Happy to just PR a delete on these files since they seem like duplicates. Thoughts?white-beach-27328
05/17/2021, 5:36 PMearly-lamp-41924
05/17/2021, 5:50 PMwhite-beach-27328
05/17/2021, 6:00 PMwhite-beach-27328
05/17/2021, 11:34 PM