https://datahubproject.io logo
Join Slack
Thread
#getting-started
    b

    big-carpet-38439

    1 year ago
    Copy to Clipboard
    Have we had discussion around support for Thrift or Protobuf for RPC?
    m

    microscopic-receptionist-23548

    1 year ago
    Copy to Clipboard
    not as far as I know; restli all the way down lol. Works well enough for JS/Java. Any particular motivation behind needing RPCs?
    b

    big-carpet-38439

    1 year ago
    Copy to Clipboard
    Mainly for the sake of making community contribution more accessible 😃
    Copy to Clipboard
    In addition Rest.li open source doesn't seem to support secure communications (TLS / SSL rpc)
    Copy to Clipboard
    @microscopic-receptionist-23548 thoughts on ^^? This seems like a risk
    m

    microscopic-receptionist-23548

    1 year ago
    Copy to Clipboard
    Yeah... that's pretty bad. But migrating off restli is going to be non trivial. I guess LI has its own authentication internally and so the OS version has fallen behind... 😕
    Copy to Clipboard
    Though that issue isn't super clear to me. Is it not a restli issue but a netty one? ssheng seems to indicate is possible in their comment to set this up
    b

    big-carpet-38439

    1 year ago
    Copy to Clipboard
    Good news: Seems like they actually have added support to their Netty server wrapper https://github.com/linkedin/rest.li/blob/bda98704c4cbfd940a41c5519deee0837124736e/[…]java/com/linkedin/r2/transport/http/server/HttpNettyServer.java
    Copy to Clipboard
    Going to confirm
    Copy to Clipboard
    The problem seems to be: Rest.li has wrappers responsible for convenient initialization of these server / servlets and if they dont expose SSL config options the client will have to figure out how to plugin their own impl of 
    HttpServer
    (possible just not ideal from a usability pov)
    Copy to Clipboard
    Looks like Restli w/ Jetty + Netty both support SSL now - awesome
    👍 1
View count: 1
Join thread in Slack