Hi Team, I am trying to retrieve a new field from ...
# getting-startedn
nutritious-bird-77396
02/11/2021, 1:31 AMHi Team, I am trying to retrieve a new field from the GMS Client API :
From what i understand from the Rest.li user guide, I have added the new field in the PDL in gms/api (https://github.com/linkedin/datahub/blob/master/gms/api/src/main/pegasus/com/linkedin/dataset/Dataset.pdl#L97)
Are there any other changes needed for these field to be retrieved from the Client?(https://github.com/linkedin/datahub/blob/master/gms/client/src/main/java/com/linkedin/dataset/client/Datasets.java)
With only these changes i see the RequestBuilder classes contain the new fields but the client doesn’t return it, i suspect I am missing some more changes….
Appreciate your help on this.
b
big-carpet-38439
02/11/2021, 1:50 AMHi @nutritious-bird-77396
big-carpet-38439
02/11/2021, 1:50 AMAre you extending the Ownership aspect, or adding a new field to top-level dataset?
big-carpet-38439
02/11/2021, 1:52 AMAnd if you are adding to Dataset.pdl have you already made changes to the DatasetAspect that you wish to change?
big-carpet-38439
02/11/2021, 1:53 AMThere is a mapping that is performed between the GMA "snapshot" + "aspect" models to the 'value' model served from the Rest.li resource, which you referenced above
big-carpet-38439
02/11/2021, 1:53 AMFor datasets, that happens here: https://github.com/linkedin/datahub/blob/master/gms/impl/src/main/java/com/linkedin/metadata/resources/dataset/Datasets.java#L125
n
nutritious-bird-77396
02/11/2021, 1:38 PMThanks a lot @big-carpet-38439. The above resource mapping is what i was missing. Appreciate your help!
🙌 1