<@U01HXE1SE23> We’re in a situation were we’d nee...
# getting-started
h
@wonderful-quill-11255 We’re in a situation were we’d need to add some BasicAuth over HTTPS functionality to RestHighLevelClientFactory.java. I think the idea would be to conditionally add a BasicCredenetialsProvider (like here) . Do you see any problems with this?
w
@high-hospital-85984 Sounds good to me!
h
Thanks! I’ll ping you in the PR to make sure I dont break the SSL functionality (I dont have a good way of testing it currently)
w
Nice. Regarding the testing I had the same issue so I just ran the quickstart stack but repointed the ES using components to our real non-prod ES. Might be worth it to have an ES docker config that starts up in SSL+auth mode but I was reluctant to add that before.
h
Ok, I have a suggestion here: https://github.com/linkedin/datahub/pull/2303 It would be great if you could review and test it against your ES instance.
g
Nice! Sorry, didn’t see it until now, but I will test asap
h
Username/password works at least (tested). I hope I didn’t break the private key path, though.
g
I can confirm that username/password works. Although the password cannot contain certain characters, e.g
#
or
@
. I haven’t tested out the more advanced SSL options like keystore etc.
it’s just the bash-scripts that has issues with special chars, so quite easy to fix by passing the credentials with a header instead. E.g
Copy code
dockerize \
  -wait $ELASTICSEARCH_PROTOCOL://$ELASTICSEARCH_HOST:$ELASTICSEARCH_PORT -wait-http-header "Authorization:Basic U3dlZGVuX2hlYXJ0OkZpbmxhbmQK"\
h
Nice catch!
g
Great job and thanks a lot for this feature btw!
🙏 1