I’m adding groups to the LDAP ingestion, is this s...
# ingestion
c
I’m adding groups to the LDAP ingestion, is this something which is of general usecase? Then I can make a PR for it.
And I don’t think that mypy typing is enforced atm? I found some inconsistencies in the types.
(Same with pylint, but not sure if that’s included.)
g
LDAP groups would probably useful generally as well, so a PR would be great, but I do think getting groups working in datahub end-to-end will be a larger endeavor
mypy typing should definitely be enforced in CI, although the entire codebase is not yet typed - what are some of the inconsistencies that you found?
we're using flake8 instead of pylint, but that too should be enforced in CI
c
Resuscitating this old thread to ask, what's the latest on groups? It looks like they can be LDAP-ingested now (yay!) but what other work were you thinking of @gray-shoe-75895 when you said "getting groups working in datahub end-to-end"?
g
The other piece of work was extending the ownership aspects to support groups - this has also already been merged in
c
Amazing. Thank you!
@gray-shoe-75895 actually - I have a few more questions. Would you be able to send me an example of groups and group ownership in the demo.datahubproject.io? Is this just simply referring to the ability to select CORP_USER vs CORP_GROUP as a type when inputing an LDAP? or are CorpGroups actually a browsable entity in their own right?
g
Yep that’s right. The two things that we don’t have yet are (1) cannot browse the full list of users/groups in the UI and (2) cannot see the list of users/subgroups within a group
c
Got it. Thank you! Just curious, have others expressed interest in those 2 features?
g
Not too much, although we probably do want to build them eventually
👍 1