<@U01GZEETMEZ> What would it take to include <http...
# ingestionh
high-hospital-85984
04/28/2021, 5:35 PM@gray-shoe-75895 What would it take to include https://github.com/linkedin/datahub/tree/master/contrib/metadata-ingestion/python/looker a part of
acryl-datahubhigh-hospital-85984
04/28/2021, 5:36 PMAs the readmes state, some functionality is missing, but would it still be ok to port over (turn into a
sourceg
gray-shoe-75895
04/28/2021, 5:40 PMPorting it over would be amazing! I think it’s fine that a bit of functionality is missing on the LookML side
l
loud-island-88694
04/28/2021, 5:41 PM
It would be great if dimensions, filters etc. can be added similar to the superset integration
loud-island-88694
04/28/2021, 5:41 PM
as part of your contribution
m
mammoth-bear-12532
04/28/2021, 5:41 PM
@bland-businessperson-65160: FYI since you were interested in this as well!
h
high-hospital-85984
04/28/2021, 5:42 PM@silly-apple-97303 Ok if we make an attempt to port your work over to
acryl-datahubhigh-hospital-85984
04/28/2021, 5:44 PMRegarding the missing functionality, has there been any talk about some generic SQL parsing functionality in the package?
g
gray-shoe-75895
04/28/2021, 6:00 PMWe’ve been thinking about it quite a bit - seems like SQL parsing will be broadly useful. However, parsing SQL is extremely complex and has a ton of edge cases, so I think we need to consider it in a principled and cohesive way
gray-shoe-75895
04/28/2021, 6:01 PMWould love to chat about it if you’ve got thoughts or ideas 🙂
s
silly-apple-97303
04/30/2021, 8:41 PMYup exactly what Harshal said, SQL parsing is so dialect specific trying to support every SQL dialect is a big challenge. At SpotHero we basically just punted on the whole problem, but it means you lose dependency information for everything in a sql block.
silly-apple-97303
04/30/2021, 8:43 PMAnd please go ahead, we threw the Looker integration out there more as a POC and there is so much to improve. Happy to see others using Looker + DataHub
3 Views