Hello everyone! I have opened a PR allowing the in...
# ingestionc
curved-sandwich-81699
04/30/2021, 3:45 PMHello everyone! I have opened a PR allowing the ingestion of Looker views built from (SQL-based) derived tables: https://github.com/linkedin/datahub/pull/2478
It is working great for us (many of our SQL-based Looker views were not ingested before). It would be nice if someone here could test and report back, hoping to get some momentum going on the Looker integration 🙂
🙌 5
b
big-carpet-38439
04/30/2021, 4:10 PMThank you very much Remi! We will take a look!
h
high-hospital-85984
04/30/2021, 4:16 PMAwesome!
high-hospital-85984
04/30/2021, 4:19 PMI was planning to move this functionality over to the ingestion package. Would that be ok?
b
big-carpet-38439
04/30/2021, 4:28 PMyeah I think it's better suited for the actual ingestion package
big-carpet-38439
04/30/2021, 4:29 PMFredrik we will need to adapt this as a metadata ingesting sink right?
m
mammoth-bear-12532
04/30/2021, 4:34 PM
@high-hospital-85984: would you like this to get in first... while you continue adapting?
mammoth-bear-12532
04/30/2021, 4:35 PM
let me know which order you prefer
mammoth-bear-12532
04/30/2021, 4:35 PM
@curved-sandwich-81699 thanks for this contribution!
👍 1
h
high-hospital-85984
04/30/2021, 5:45 PMI haven’ started yet, so merge this first! Will likely start next week