Hey, I've noticed that LookML ingestion plugin doe...
# ingestionr
rhythmic-london-44496
08/25/2021, 2:50 PMHey, I've noticed that LookML ingestion plugin doesn't parse includes in a recursive manner, and because of that, some views might not be ingested. Should I create a github issue for it?
👀 1
m
mammoth-bear-12532
08/25/2021, 3:33 PM
Please do! /cc @high-hospital-85984 @orange-airplane-6566 who are experts in lookml
thankyou 1
👌 1
r
rhythmic-london-44496
09/15/2021, 1:01 PMhttps://github.com/linkedin/datahub/issues/3239 here is the issue. Sorry for the delay 🙏
m
mammoth-bear-12532
09/15/2021, 2:16 PM
@rhythmic-london-44496: Thanks! Were you thinking of working on it?
r
rhythmic-london-44496
09/15/2021, 2:24 PMYeah, I can work on it, I will try to come up with something in a week or two 👍
rhythmic-london-44496
09/16/2021, 3:25 PM@high-hospital-85984 @orange-airplane-6566 here is the draft of a fix -> https://github.com/linkedin/datahub/pull/3248/files I've should probably introduce a check in order to discover circular dependencies. Should I continue placing this code there or do you think it would be better to reorganize the code? I wonder how we can improve ingesting the views. Right now a lot of information seems to be lost and it's hard to map what's in datahub with what's in Looker. What about Looker explores?
m
mammoth-bear-12532
09/16/2021, 3:27 PM
@rhythmic-london-44496 we have some improvements coming there. PR should be coming today!
🙌 1