Hey, I'm currently building an API gateway in fron...
# ingestion
c
Hey, I'm currently building an API gateway in front of the GMS endpoint. However the RestEmitter does not accept custom /additional headers. So currently to get it to work I've monkey patched it with my own addition. Would it be of interest to allow a param
extra_headers
or something which would be k,v to add to the emitter? Then for future usecases people could add whatever they want if they would need it.
m
Sounds reasonable. Would these headers be static configed thru from the yaml?
c
yep
m
or would these be dynamically set by the source
c
I was thinking you just add something in the yaml config and we just pass it in through to the rest emitter, just like the token atm.
m
yeah that works
extra_headers: key: value
c
Yep, cool. I'll make a PR tomorrow, gtg now. Was just working on this so it's nice that it doesn't have to live at our side.
m
👍
b
@calm-sunset-28996 Doesn't our rest emitter allow for headers?
Like the authorization header etc
Just took a look - it does support a "token" parameter that will be inserted into an Authorization header if provided. Does this work for you?
c
Hey John, thanks for the feedback. Yeah I saw that but I'm not trying to add a token so that does not really work for me. And then I was thinking that adding a specific option for every possible header might be a bad idea so why not allow custom k,v's to be injected. I'll link a proposal in a bit, it will be a rather small change.
Made a PR for this here. Shows a bit better what I've meant.
b
Thanks Adriaan! Will take a look
yeah this looks great
Simple. straightforward, clear. Great PR!