Hi guys After applying pinned posts I think we should do a m DataHub #ui

Hi guys, After applying pinned posts, I think we ...

famous-florist-7218

10/20/2022, 9:57 AM

Hi guys, After applying pinned posts, I think we should do a minor change on the UI. Specifically, two div class of

Pinned Post

and

Domains

overlap each other. My thought is removing

margin-top

DomainsRecomendationContainer

config. Does it look good? cc @green-football-43791

Copy code

const DomainsRecomendationContainer = styled.div`
    margin-top: -48px;
    margin-bottom: 32px;
    max-width: 1000px;
    min-width: 750px;
`;

big-carpet-38439

10/21/2022, 9:42 PM

Thank you!

big-carpet-38439

10/21/2022, 9:42 PM

I know @echoing-airport-49548 was planning to raise a PR to the same effect early next week - to address the margin issues people are facing

big-carpet-38439

10/21/2022, 9:42 PM

Ill let him take a look 🙂

famous-florist-7218

10/22/2022, 2:20 AM

Thanks @big-carpet-38439

echoing-airport-49548

10/24/2022, 4:29 PM

Hey @famous-florist-7218 sorry I was on vacation last week but I can take a look at this today! Thanks for raising this PR

echoing-airport-49548

10/24/2022, 11:29 PM

Responded on the PR, but I think we should close that PR in favor of this one https://github.com/datahub-project/datahub/pull/6234

famous-florist-7218

10/25/2022, 1:13 PM

This PR has been closed. Thanks @echoing-airport-49548

echoing-airport-49548

10/25/2022, 4:29 PM

Thanks! I’ll keep you updated when this one goes in