Hi, could someone take a look at this ready PR ? <...
# contribute-codep
purple-monitor-41675
09/07/2022, 8:04 PMHi, could someone take a look at this ready PR ? https://github.com/datahub-project/datahub/pull/5683
✅ 1
s
square-activity-64562
09/08/2022, 9:31 AMI can see Pedro and Peter have already looked through it. Added 1 comment. If that is satisfied/answered we should be able to merge it in.
i
incalculable-ocean-74010
09/08/2022, 5:05 PMHey @purple-monitor-41675
Can you address the last comment so we can merge this in?
Thanks!
p
purple-monitor-41675
09/08/2022, 10:36 PM@square-activity-64562 could you explain more what you mean by your comment ? I am new to the project and don’t know much about python packaging.
Thanks in advance
s
square-activity-64562
09/09/2022, 10:02 AMI misunderstood. Re-running the checks and then will merge if checks pass
square-activity-64562
09/12/2022, 8:13 AMThere is a merge conflict. Can you please resolve merge conflicts?
square-activity-64562
09/13/2022, 7:16 AMHi @purple-monitor-41675 There is a merge conflict. Can you please resolve them so we can merge this in?
p
purple-monitor-41675
09/15/2022, 8:32 PMThanks @square-activity-64562 for resolving the conflict and merging it. Haven’t found the time to look at it in the last few days. 😉