Hi! I am trying to deploy Datahub in kebernetes with datahub-helm repository. But while configuring/customising Ingress for datahub-frontend and datahub-gms I came across a problem with lack of support for adding custom labels to Ingress. My organization needs some special labels to route the traffic and setup firewalls. My current Ingress config labels look like here:

Name:             datahub-datahub-frontend
Labels:           <http://app.kubernetes.io/instance=datahub|app.kubernetes.io/instance=datahub>
                  <http://app.kubernetes.io/managed-by=Helm|app.kubernetes.io/managed-by=Helm>
                  <http://app.kubernetes.io/name=datahub-frontend|app.kubernetes.io/name=datahub-frontend>
                  <http://app.kubernetes.io/version=0.3.3|app.kubernetes.io/version=0.3.3>
                  <http://helm.sh/chart=datahub-frontend-0.2.4|helm.sh/chart=datahub-frontend-0.2.4>

I would like to add another label to the end of the list like here:

Name:             datahub-datahub-frontend
Labels:           <http://app.kubernetes.io/instance=datahub|app.kubernetes.io/instance=datahub>
                  <http://app.kubernetes.io/managed-by=Helm|app.kubernetes.io/managed-by=Helm>
                  <http://app.kubernetes.io/name=datahub-frontend|app.kubernetes.io/name=datahub-frontend>
                  <http://app.kubernetes.io/version=0.3.3|app.kubernetes.io/version=0.3.3>
                  <http://helm.sh/chart=datahub-frontend-0.2.4|helm.sh/chart=datahub-frontend-0.2.4>
                  traffic-type=public

Is there any way to do it with current helm repo config or it requires a change?

above labels are populated from helm template

datahub-frontend.labels

defined here - https://github.com/acryldata/datahub-helm/blob/master/charts/datahub/subcharts/datahub-frontend/templates/_helpers.tpl#:~:text=%7B%7[…]2%20%2D%7D%7D You can modify it to add additional labels as per your requirement

I’m installing the frontend from the umbrella chart for datahub You mean I should submit a change request to the datahub-helm repo? or in the forked copy of datahub-frontend helm chart? I see a similar situation with datahub-gms Ingress configuration also 🙂

since these labels are specific to your organization, you can update it in your forked repository

Right.. but just for one additional custom label I have to fork two repos. I believe having an option to add custom labels would be a generic requirement for many. I would like to give a try if the community allows me to submit a change request. Is that here? #feature-requests

if you would like to contribute you can use the #contribute channel to discuss how to contribute

Nice.. thanks 🙂