<@UV0M2EB8Q> We were testing the ability to add a ...
# troubleshootb
brave-zebra-97479
09/02/2022, 8:51 PM@mammoth-bear-12532 We were testing the ability to add a new entity type by using a custom repository and we ran into an exception that tell us that adding a new entity type that way is not supported. You told us earlier that this should be possible, but it doesn't seem to be. FWIW I can see from the commit history that you were the one that added the exception logic. Does this check just need to be removed, or is there some other piece of the puzzle missing? If it can be removed, I can try making the change and sending a pull request.
m
mammoth-bear-12532
09/04/2022, 10:14 PM
@brave-zebra-97479: yes, let's remove the logic. Sorry for the trouble. Would be super glad to process that PR!
b
brave-zebra-97479
09/06/2022, 2:52 AM@mammoth-bear-12532 I've created a pull request here: https://github.com/datahub-project/datahub/pull/5831
brave-zebra-97479
09/06/2022, 7:46 PM@mammoth-bear-12532 I've updated the pull request.
brave-zebra-97479
09/08/2022, 2:19 AM@mammoth-bear-12532 I've been testing the ability to ingest an entity defined in the patch registry and I think there need to be some additional code changes. It looks like when trying to parse a Urn from a metadata change proposal, it tries to load the class associated with the key aspect. However, the classes from the patch registry are not part of the classpath, so it always fails. I was able to get it to work in my local with some changes, but I'm not sure if my strategy for the changes is safe. Is there someone I can talk to in depth about this?
m
mammoth-bear-12532
09/08/2022, 5:05 AM
Hey @brave-zebra-97479 that would be me or @orange-night-91387
b
brave-zebra-97479
09/08/2022, 4:09 PMI started a chat between us three where I posted my findings.